Remove obsolete group() method

Author: vovannikov

src/structure_new/src/nonlinear_solver/4C_structure_new_nln_solver_generic.cpp

@@ -61,18 +61,12 @@ Teuchos::RCP<::NOX::Abstract::Group>& Solid::Nln::SOLVER::Generic::group_ptr()
 
 /*----------------------------------------------------------------------------*
  *----------------------------------------------------------------------------*/
-::NOX::Abstract::Group& Solid::Nln::SOLVER::Generic::group()
+::NOX::Abstract::Group& Solid::Nln::SOLVER::Generic::get_solution_group()
 {
-  check_init();
+  check_init_setup();
   FOUR_C_ASSERT(group_ptr_, "The group pointer should be initialized beforehand!");
-  return *group_ptr_;
-}
 
-/*----------------------------------------------------------------------------*
- *----------------------------------------------------------------------------*/
-::NOX::Abstract::Group& Solid::Nln::SOLVER::Generic::get_solution_group()
-{
-  return group();
+  return *group_ptr_;
 }
 
 /*----------------------------------------------------------------------------*

src/structure_new/src/nonlinear_solver/4C_structure_new_nln_solver_generic.hpp

@@ -188,7 +188,6 @@ namespace Solid
         /*! returns the nox group (pointer) (only for internal use)
          *
          *  The nox group has to be initialized in one of the derived setup() routines. */
-        ::NOX::Abstract::Group& group();
         Teuchos::RCP<::NOX::Abstract::Group>& group_ptr();
 
        protected:

src/structure_new/src/nonlinear_solver/4C_structure_new_nln_solver_singlestep.cpp

@@ -104,9 +104,9 @@ enum Inpar::Solid::ConvergenceStatus Solid::Nln::SOLVER::SingleStep::solve()
 {
   check_init_setup();
 
-  auto& nln_group = dynamic_cast<NOX::Nln::Group&>(group());
+  auto& nln_group = dynamic_cast<NOX::Nln::Group&>(*group_ptr());
 
-  const auto& x_epetra = dynamic_cast<const ::NOX::Epetra::Vector&>(group().getX());
+  const auto& x_epetra = dynamic_cast<const ::NOX::Epetra::Vector&>(group_ptr()->getX());
 
   nln_group.set_is_valid_newton(true);  // to circumvent the check in ::NOX::Solver::SingleStep
   nln_group.set_is_valid_rhs(false);    // force to compute the RHS