Use the same internal numbering for direct Exodus input #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with dat-style input
c-p-schmidt
approved these changes
May 5, 2025
ischeider
approved these changes
May 5, 2025
Contributor
ischeider
left a comment
ischeider
left a comment
There was a problem hiding this comment.
You didn't change the FOUR_C_THROW calls after an if-clause into a FOUR_C_ASSERT. Is there any policy which one to use generally?
Member
Author
|
@ischeider I don't think there is a policy. Do you want to add some guidance on that? This could go into the coding guidelines. I use both styles, depending on the context. Sometimes, I want to construct a complex error message. In this case, the manual if is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #733 (which is rather difficult to complete). Closes #731