[DURACOM-327] move mocks and routing functions + remaining references of AppState + move notification state in core

Author: FrancescoMolinaro

scripts/base-href.ts

@@ -2,7 +2,7 @@ import { existsSync, writeFileSync } from 'fs';
 import { join } from 'path';
 
 import { AppConfig } from '../src/app/core/config/app-config.interface';
-import { buildAppConfig } from '../src/app/core/config/config.server';
+import { buildAppConfig } from '../src/config/config.server';
 
 /**
  * Script to set baseHref as `ui.nameSpace` for development mode. Adds `baseHref` to angular.json build options.

scripts/serve.ts

@@ -1,7 +1,7 @@
 import { spawn } from 'child_process';
 
 import { AppConfig } from '../src/app/core/config/app-config.interface';
-import { buildAppConfig } from '../src/app/core/config/config.server';
+import { buildAppConfig } from '../src/config/config.server';
 
 const appConfig: AppConfig = buildAppConfig();
 

scripts/test-rest.ts

@@ -2,7 +2,7 @@ import { request } from 'http';
 import { request as https_request } from 'https';
 
 import { AppConfig } from '../src/app/core/config/app-config.interface';
-import { buildAppConfig } from '../src/app/core/config/config.server';
+import { buildAppConfig } from '../src/config/config.server';
 
 const appConfig: AppConfig = buildAppConfig();
 

server.ts

@@ -44,7 +44,7 @@ import { createProxyMiddleware } from 'http-proxy-middleware';
 import { hasValue } from './modules/shared/utils/src/lib/utils/empty.util';
 import { UIServerConfig } from './src/app/core/config/ui-server-config.interface';
 import bootstrap from './src/main.server';
-import { buildAppConfig } from './src/app/core/config/config.server';
+import { buildAppConfig } from './src/config/config.server';
 import {
   APP_CONFIG,
   AppConfig,

src/app/access-control/bulk-access/bulk-access.component.spec.ts

@@ -8,9 +8,9 @@ import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
 import { NotificationsService } from '../../core/notifications/notifications.service';
+import { Process } from '../../core/processes/process.model';
 import { createSuccessfulRemoteDataObject$ } from '../../core/utilities/remote-data.utils';
 import { NotificationsServiceStub } from '../../core/utilities/testing/notifications-service.stub';
-import { Process } from '../../process-page/processes/process.model';
 import { BulkAccessControlService } from '../../shared/access-control-form-container/bulk-access-control.service';
 import { getMockThemeService } from '../../shared/mocks/theme-service.mock';
 import { SelectableListState } from '../../shared/object-list/selectable-list/selectable-list.reducer';

src/app/access-control/epeople-registry/epeople-registry.component.spec.ts

@@ -40,6 +40,7 @@ import { RemoteData } from '../../core/data/remote-data';
 import { RequestService } from '../../core/data/request.service';
 import { EPersonDataService } from '../../core/eperson/eperson-data.service';
 import { EPerson } from '../../core/eperson/models/eperson.model';
+import { RouterMock } from '../../core/mocks/router.mock';
 import { NotificationsService } from '../../core/notifications/notifications.service';
 import { PaginationService } from '../../core/pagination/pagination.service';
 import { PageInfo } from '../../core/shared/page-info.model';
@@ -54,7 +55,6 @@ import { BtnDisabledDirective } from '../../shared/btn-disabled.directive';
 import { FormBuilderService } from '../../shared/form/builder/form-builder.service';
 import { ThemedLoadingComponent } from '../../shared/loading/themed-loading.component';
 import { getMockFormBuilderService } from '../../shared/mocks/form-builder-service.mock';
-import { RouterMock } from '../../shared/mocks/router.mock';
 import { PaginationComponent } from '../../shared/pagination/pagination.component';
 import { EPeopleRegistryComponent } from './epeople-registry.component';
 import { EPersonFormComponent } from './eperson-form/eperson-form.component';

src/app/access-control/group-registry/group-form/group-form.component.spec.ts

@@ -44,6 +44,7 @@ import { RemoteData } from '../../../core/data/remote-data';
 import { EPersonDataService } from '../../../core/eperson/eperson-data.service';
 import { GroupDataService } from '../../../core/eperson/group-data.service';
 import { Group } from '../../../core/eperson/models/group.model';
+import { RouterMock } from '../../../core/mocks/router.mock';
 import { NotificationsService } from '../../../core/notifications/notifications.service';
 import { DSpaceObject } from '../../../core/shared/dspace-object.model';
 import { HALEndpointService } from '../../../core/shared/hal-endpoint.service';
@@ -64,7 +65,6 @@ import { FormBuilderService } from '../../../shared/form/builder/form-builder.se
 import { FormComponent } from '../../../shared/form/form.component';
 import { DSONameServiceMock } from '../../../shared/mocks/dso-name.service.mock';
 import { getMockFormBuilderService } from '../../../shared/mocks/form-builder-service.mock';
-import { RouterMock } from '../../../shared/mocks/router.mock';
 import { GroupFormComponent } from './group-form.component';
 import { MembersListComponent } from './members-list/members-list.component';
 import { SubgroupsListComponent } from './subgroup-list/subgroups-list.component';

src/app/access-control/group-registry/group-form/members-list/members-list.component.spec.ts

@@ -46,6 +46,8 @@ import { EPersonDataService } from '../../../../core/eperson/eperson-data.servic
 import { GroupDataService } from '../../../../core/eperson/group-data.service';
 import { EPerson } from '../../../../core/eperson/models/eperson.model';
 import { Group } from '../../../../core/eperson/models/group.model';
+import { RouterMock } from '../../../../core/mocks/router.mock';
+import { getMockTranslateService } from '../../../../core/mocks/translate.service.mock';
 import { NotificationsService } from '../../../../core/notifications/notifications.service';
 import { PaginationService } from '../../../../core/pagination/pagination.service';
 import { PageInfo } from '../../../../core/shared/page-info.model';
@@ -63,8 +65,6 @@ import { ContextHelpDirective } from '../../../../shared/context-help.directive'
 import { FormBuilderService } from '../../../../shared/form/builder/form-builder.service';
 import { DSONameServiceMock } from '../../../../shared/mocks/dso-name.service.mock';
 import { getMockFormBuilderService } from '../../../../shared/mocks/form-builder-service.mock';
-import { RouterMock } from '../../../../shared/mocks/router.mock';
-import { getMockTranslateService } from '../../../../shared/mocks/translate.service.mock';
 import { PaginationComponent } from '../../../../shared/pagination/pagination.component';
 import { MembersListComponent } from './members-list.component';
 

src/app/access-control/group-registry/group-form/subgroup-list/subgroups-list.component.spec.ts

@@ -43,6 +43,8 @@ import {
 import { RemoteData } from '../../../../core/data/remote-data';
 import { GroupDataService } from '../../../../core/eperson/group-data.service';
 import { Group } from '../../../../core/eperson/models/group.model';
+import { RouterMock } from '../../../../core/mocks/router.mock';
+import { getMockTranslateService } from '../../../../core/mocks/translate.service.mock';
 import { NotificationsService } from '../../../../core/notifications/notifications.service';
 import { PaginationService } from '../../../../core/pagination/pagination.service';
 import { PageInfo } from '../../../../core/shared/page-info.model';
@@ -60,8 +62,6 @@ import { ContextHelpDirective } from '../../../../shared/context-help.directive'
 import { FormBuilderService } from '../../../../shared/form/builder/form-builder.service';
 import { DSONameServiceMock } from '../../../../shared/mocks/dso-name.service.mock';
 import { getMockFormBuilderService } from '../../../../shared/mocks/form-builder-service.mock';
-import { RouterMock } from '../../../../shared/mocks/router.mock';
-import { getMockTranslateService } from '../../../../shared/mocks/translate.service.mock';
 import { PaginationComponent } from '../../../../shared/pagination/pagination.component';
 import { SubgroupsListComponent } from './subgroups-list.component';
 

src/app/access-control/group-registry/groups-registry.component.spec.ts

@@ -45,6 +45,7 @@ import { EPersonDataService } from '../../core/eperson/eperson-data.service';
 import { GroupDataService } from '../../core/eperson/group-data.service';
 import { EPerson } from '../../core/eperson/models/eperson.model';
 import { Group } from '../../core/eperson/models/group.model';
+import { RouterMock } from '../../core/mocks/router.mock';
 import { NotificationsService } from '../../core/notifications/notifications.service';
 import { PaginationService } from '../../core/pagination/pagination.service';
 import { RouteService } from '../../core/services/route.service';
@@ -69,7 +70,6 @@ import {
   DSONameServiceMock,
   UNDEFINED_NAME,
 } from '../../shared/mocks/dso-name.service.mock';
-import { RouterMock } from '../../shared/mocks/router.mock';
 import { PaginationComponent } from '../../shared/pagination/pagination.component';
 import { GroupsRegistryComponent } from './groups-registry.component';