[DURACOM-327] move core dependencies (imported files) into core folder, move config (app) into core, move core states files into core folder, replace import of some constants for route paths with strings to avoid import/dependency from other part of the app

Author: FrancescoMolinaro

src/app/access-control/bulk-access/browse/bulk-access-browse.component.spec.ts

@@ -11,10 +11,10 @@ import {
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
-import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import { buildPaginatedList } from '../../../core/data/paginated-list.model';
 import { getMockThemeService } from '../../../core/mocks/theme-service.mock';
 import { PageInfo } from '../../../core/shared/page-info.model';
+import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import { ListableObjectComponentLoaderComponent } from '../../../shared/object-collection/shared/listable-object/listable-object-component-loader.component';
 import { SelectableListItemControlComponent } from '../../../shared/object-collection/shared/selectable-list-item-control/selectable-list-item-control.component';
 import { SelectableListService } from '../../../shared/object-list/selectable-list/selectable-list.service';

src/app/access-control/bulk-access/browse/bulk-access-browse.component.ts

@@ -21,7 +21,6 @@ import {
   map,
 } from 'rxjs/operators';
 
-import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import {
   buildPaginatedList,
   PaginatedList,
@@ -31,6 +30,7 @@ import { ListableObject } from '../../../core/object-collection/listable-object.
 import { PageInfo } from '../../../core/shared/page-info.model';
 import { PaginationComponentOptions } from '../../../core/shared/pagination-component-options.model';
 import { SearchConfigurationService } from '../../../core/shared/search/search-configuration.service';
+import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import { SEARCH_CONFIG_SERVICE } from '../../../my-dspace-page/my-dspace-configuration.service';
 import { ListableObjectComponentLoaderComponent } from '../../../shared/object-collection/shared/listable-object/listable-object-component-loader.component';
 import { SelectableListItemControlComponent } from '../../../shared/object-collection/shared/selectable-list-item-control/selectable-list-item-control.component';

src/app/admin/admin-ldn-services/ldn-service-serviceMock/ldnServicesRD$-mock.ts

@@ -3,9 +3,9 @@ import {
   of,
 } from 'rxjs';
 
-import { createSuccessfulRemoteDataObject$ } from '../../../core/utilities/remote-data.utils';
 import { PaginatedList } from '../../../core/data/paginated-list.model';
 import { RemoteData } from '../../../core/data/remote-data';
+import { createSuccessfulRemoteDataObject$ } from '../../../core/utilities/remote-data.utils';
 import { LDN_SERVICE } from '../ldn-services-model/ldn-service.resource-type';
 import { LdnService } from '../ldn-services-model/ldn-services.model';
 

src/app/bitstream-page/bitstream-authorizations/bitstream-authorizations.component.spec.ts

@@ -16,10 +16,10 @@ import {
 import { cold } from 'jasmine-marbles';
 import { of as observableOf } from 'rxjs';
 
-import { createSuccessfulRemoteDataObject } from '../../core/utilities/remote-data.utils';
 import { TranslateLoaderMock } from '../../core/mocks/translate-loader.mock';
 import { Bitstream } from '../../core/shared/bitstream.model';
 import { DSpaceObject } from '../../core/shared/dspace-object.model';
+import { createSuccessfulRemoteDataObject } from '../../core/utilities/remote-data.utils';
 import { ResourcePoliciesComponent } from '../../shared/resource-policies/resource-policies.component';
 import { BitstreamAuthorizationsComponent } from './bitstream-authorizations.component';
 

src/app/bitstream-page/bitstream-download-page/bitstream-download-page.component.spec.ts

@@ -12,7 +12,6 @@ import {
 import { TranslateModule } from '@ngx-translate/core';
 import { of as observableOf } from 'rxjs';
 
-import { createSuccessfulRemoteDataObject } from '../../core/utilities/remote-data.utils';
 import { getForbiddenRoute } from '../../app-routing-paths';
 import { AuthService } from '../../core/auth/auth.service';
 import { AuthorizationDataService } from '../../core/data/feature-authorization/authorization-data.service';
@@ -21,6 +20,7 @@ import { HardRedirectService } from '../../core/services/hard-redirect.service';
 import { ServerResponseService } from '../../core/services/server-response.service';
 import { Bitstream } from '../../core/shared/bitstream.model';
 import { FileService } from '../../core/shared/file.service';
+import { createSuccessfulRemoteDataObject } from '../../core/utilities/remote-data.utils';
 import { BitstreamDownloadPageComponent } from './bitstream-download-page.component';
 
 describe('BitstreamDownloadPageComponent', () => {

src/app/bitstream-page/bitstream-page-authorizations.guard.spec.ts

@@ -11,9 +11,9 @@ import { AuthService } from 'src/app/core/auth/auth.service';
 import { AuthorizationDataService } from 'src/app/core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from 'src/app/core/data/feature-authorization/feature-id';
 
-import { createSuccessfulRemoteDataObject$ } from '../core/utilities/remote-data.utils';
 import { BitstreamDataService } from '../core/data/bitstream-data.service';
 import { Bitstream } from '../core/shared/bitstream.model';
+import { createSuccessfulRemoteDataObject$ } from '../core/utilities/remote-data.utils';
 import { bitstreamPageAuthorizationsGuard } from './bitstream-page-authorizations.guard';
 
 describe('bitstreamPageAuthorizationsGuard', () => {

src/app/bitstream-page/bitstream-page-routes.ts

@@ -3,13 +3,13 @@ import { Route } from '@angular/router';
 import { authenticatedGuard } from '../core/auth/authenticated.guard';
 import { bitstreamBreadcrumbResolver } from '../core/breadcrumbs/bitstream-breadcrumb.resolver';
 import { i18nBreadcrumbResolver } from '../core/breadcrumbs/i18n-breadcrumb.resolver';
+import { bitstreamPageResolver } from '../core/shared/resolvers/bitstream-page.resolver';
 import { ResourcePolicyCreateComponent } from '../shared/resource-policies/create/resource-policy-create.component';
 import { ResourcePolicyEditComponent } from '../shared/resource-policies/edit/resource-policy-edit.component';
 import { resourcePolicyResolver } from '../shared/resource-policies/resolvers/resource-policy.resolver';
 import { resourcePolicyTargetResolver } from '../shared/resource-policies/resolvers/resource-policy-target.resolver';
 import { BitstreamAuthorizationsComponent } from './bitstream-authorizations/bitstream-authorizations.component';
 import { BitstreamDownloadPageComponent } from './bitstream-download-page/bitstream-download-page.component';
-import { bitstreamPageResolver } from '../core/shared/resolvers/bitstream-page.resolver';
 import { bitstreamPageAuthorizationsGuard } from './bitstream-page-authorizations.guard';
 import { ThemedEditBitstreamPageComponent } from './edit-bitstream-page/themed-edit-bitstream-page.component';
 import { legacyBitstreamURLRedirectGuard } from './legacy-bitstream-url-redirect.guard';

src/app/collection-page/create-collection-page/create-collection-page.guard.spec.ts

@@ -1,11 +1,11 @@
 import { first } from 'rxjs/operators';
 
+import { RouterMock } from '../../core/mocks/router.mock';
+import { Community } from '../../core/shared/community.model';
 import {
   createFailedRemoteDataObject$,
   createSuccessfulRemoteDataObject$,
 } from '../../core/utilities/remote-data.utils';
-import { RouterMock } from '../../core/mocks/router.mock';
-import { Community } from '../../core/shared/community.model';
 import { createCollectionPageGuard } from './create-collection-page.guard';
 
 describe('createCollectionPageGuard', () => {

src/app/collection-page/edit-collection-page/collection-access-control/collection-access-control.component.spec.ts

@@ -8,8 +8,8 @@ import {
   of,
 } from 'rxjs';
 
-import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import { Community } from '../../../core/shared/community.model';
+import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import { AccessControlFormContainerComponent } from '../../../shared/access-control-form-container/access-control-form-container.component';
 import { CollectionAccessControlComponent } from './collection-access-control.component';
 

src/app/collection-page/edit-collection-page/collection-authorizations/collection-authorizations.component.spec.ts

@@ -12,9 +12,9 @@ import { ActivatedRoute } from '@angular/router';
 import { cold } from 'jasmine-marbles';
 import { of as observableOf } from 'rxjs';
 
-import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import { Collection } from '../../../core/shared/collection.model';
 import { DSpaceObject } from '../../../core/shared/dspace-object.model';
+import { createSuccessfulRemoteDataObject } from '../../../core/utilities/remote-data.utils';
 import { ResourcePoliciesComponent } from '../../../shared/resource-policies/resource-policies.component';
 import { CollectionAuthorizationsComponent } from './collection-authorizations.component';