Merged in task/dspace-cris-2023_02_x/DSC-1742 (pull request DSpace#2509)

[DSC-1742] Resolves language change using query params during SSR

Approved-by: Giuseppe Digilio

Author: alisaismailati

src/app/core/locale/locale.service.spec.ts

@@ -11,6 +11,7 @@ import { NativeWindowRef } from '../services/window.service';
 import { RouteService } from '../services/route.service';
 import { routeServiceStub } from '../../shared/testing/route-service.stub';
 import { of as observableOf } from 'rxjs';
+import { PLATFORM_ID } from '@angular/core';
 
 describe('LocaleService test suite', () => {
   let service: LocaleService;
@@ -24,6 +25,7 @@ describe('LocaleService test suite', () => {
   let routeService;
   let document;
   let spyOnGetLanguage;
+  const platformId = 'browser';
 
 
   const translateServiceStub: any = {
@@ -62,6 +64,7 @@ describe('LocaleService test suite', () => {
           { provide: RouteService, useValue: routeServiceStub },
           { provide: TranslateService, useValue: translateServiceStub },
           { provide: Document, useValue: document },
+          { provide: PLATFORM_ID, useValue: platformId },
         ]
       });
     }));
@@ -72,7 +75,7 @@ describe('LocaleService test suite', () => {
       routeService = TestBed.inject(RouteService);
       window = new NativeWindowRef();
       document = { documentElement: { lang: 'en' } };
-      service = new LocaleService(window, cookieService, translateService, authService, routeService, document);
+      service = new LocaleService(window, cookieService, translateService, authService, routeService, document, platformId);
       serviceAsAny = service;
       spyOnGet = spyOn(cookieService, 'get');
       spyOnSet = spyOn(cookieService, 'set');

src/app/core/locale/locale.service.ts

@@ -1,4 +1,4 @@
-import { Inject, Injectable } from '@angular/core';
+import { Inject, Injectable, PLATFORM_ID } from '@angular/core';
 
 import { TranslateService } from '@ngx-translate/core';
 
@@ -10,7 +10,7 @@ import { combineLatest, Observable, of as observableOf } from 'rxjs';
 import { map, mergeMap, take } from 'rxjs/operators';
 import { NativeWindowRef, NativeWindowService } from '../services/window.service';
 import { RouteService } from '../services/route.service';
-import { DOCUMENT } from '@angular/common';
+import { DOCUMENT, isPlatformBrowser } from '@angular/common';
 import { LangConfig } from '../../../config/lang-config.interface';
 
 export const LANG_COOKIE = 'dsLanguage';
@@ -41,7 +41,8 @@ export class LocaleService {
     protected translate: TranslateService,
     protected authService: AuthService,
     protected routeService: RouteService,
-    @Inject(DOCUMENT) protected document: any
+    @Inject(DOCUMENT) protected document: any,
+    @Inject(PLATFORM_ID) protected platformId: string,
   ) {
     this.initDefaults();
   }
@@ -53,7 +54,9 @@ export class LocaleService {
     this.routeService.getQueryParameterValue('lang').subscribe(lang => {
       if (lang && this.translate.getLangs().includes(lang)) {
         this.setCurrentLanguageCode(lang);
-        this.routeService.removeQueryParam('lang');
+        if (isPlatformBrowser(this.platformId)) {
+          this.routeService.removeQueryParam('lang');
+        }
       }
     });
   }

src/app/core/locale/server-locale.service.ts

@@ -1,5 +1,5 @@
 import { LANG_ORIGIN, LocaleService } from './locale.service';
-import { Inject, Injectable } from '@angular/core';
+import { Inject, Injectable, PLATFORM_ID } from '@angular/core';
 import { combineLatest, Observable, of as observableOf } from 'rxjs';
 import { map, mergeMap, take } from 'rxjs/operators';
 import { hasValue, isEmpty, isNotEmpty } from '../../shared/empty.util';
@@ -21,9 +21,10 @@ export class ServerLocaleService extends LocaleService {
     protected translate: TranslateService,
     protected authService: AuthService,
     protected routeService: RouteService,
-    @Inject(DOCUMENT) protected document: any
+    @Inject(DOCUMENT) protected document: any,
+    @Inject(PLATFORM_ID) protected platformId: string,
   ) {
-    super(_window, cookie, translate, authService, routeService, document);
+    super(_window, cookie, translate, authService, routeService, document, platformId);
   }
 
   /**