fix: refactor URL handling in getURLParameterValue and _getList functions for improved clarity and functionality

Author: yannicktrinh

Project/Sources/Classes/Tools.4dm

@@ -266,27 +266,14 @@ Function getPortFromURL($inURL : Text) : Integer
 	// ----------------------------------------------------
 
 
-Function getURLParameterValue($URL : Text; $paramName : Text) : Text
+Function getURLParameterValue($inURL : Text; $inParamName : Text) : Text
 
-	var $result : Text
-	var $posQuery : Integer:=Position("?"; $URL)
-	If ($posQuery>0)
-		
-		var $queryString : Text:=Substring($URL; $posQuery+1)
-		var $parameters : Collection:=Split string($queryString; "&"; sk ignore empty strings)
-		var $parameter : Text
-		
-		For each ($parameter; $parameters)
-			
-			var $values : Collection:=Split string($parameter; "=")
-			
-			If ($values.length=2)
-				If ($values[0]=$paramName)
-					$result:=$values[1]
-					break
-				End if 
-			End if 
-		End for each 
+	var $result : Text:=""
+	var $URL : cs.URL:=cs.URL.new($inURL)
+	var $foundParam : Object:=$URL.queryParams.find(Formula($1.value.name=$2); $inParamName)
+	
+	If ((Value type($foundParam)=Is object) && (OB Is defined($foundParam; "value")))
+		$result:=$foundParam.value
 	End if 
 
 	return $result
@@ -582,7 +569,7 @@ Function makeError($inCode : Integer; $inParameters : Object) : Object
 
 
 Function buildPageFromTemplate($inTitle : Text; $inMessage : Text; $inDetails : Text; $inButtonText : Text) : Text
-	/*
+/*
 		Builds a response page from the template file.
 		Parameters:
 			- $inTitle: Title of the page

Project/Sources/Classes/_GoogleBaseList.4dm

@@ -32,16 +32,14 @@ Class constructor($inProvider : cs.OAuth2Provider; $inParameters : Object)
 
 Function _getList($inPageToken : Text) : Boolean
 
-	var $URL : Text:=This._internals._URL
+	var $URL : cs.URL:=cs.URL.new(This._internals._URL)
 
 	If (Length(String($inPageToken))>0)
-		
-		var $sep : Text:=((Position("?"; $URL)=0) ? "?" : "&")
-		$URL+=$sep+"pageToken="+$inPageToken
+		$URL.addQueryParameter("pageToken"; inPageToken)
 	End if 
 
 	Super._throwErrors(False)
-	var $response : Object:=Super._sendRequestAndWaitResponse("GET"; $URL; This._internals._headers)
+	var $response : Object:=Super._sendRequestAndWaitResponse("GET"; $URL.toString(); This._internals._headers)
 	Super._throwErrors(True)
 
 	This.isLastPage:=False