Skip to content

Commit 67e20f8

Browse files
committed
fix: correct variable name in constructor and response handling
1 parent 4f9c3dd commit 67e20f8

File tree

4 files changed

+15
-14
lines changed

4 files changed

+15
-14
lines changed

Project/Sources/Classes/GoogleEventAttachment.4dm

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ property mimeType : Text
44
property iconLink : Text
55
property contentBytes : 4D.Blob:=Null
66

7-
Class constructor($inAttachement : Object)
7+
Class constructor($inAttachment : Object)
88

9-
This.fileUrl:=String($inAttachement.fileUrl)
10-
This.title:=String($inAttachement.title)
11-
This.mimeType:=String($inAttachement.mimeType)
12-
This.iconLink:=String($inAttachement.iconLink)
9+
This.fileUrl:=String($inAttachment.fileUrl)
10+
This.title:=String($inAttachment.title)
11+
This.mimeType:=String($inAttachment.mimeType)
12+
This.iconLink:=String($inAttachment.iconLink)
1313

1414

1515
// Mark: - [Public]

Project/Sources/Classes/Tools.4dm

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ Function urlDecode($inURL : Text) : Text
484484
See: https://github.com/4d/4D-SVG project
485485
*/
486486
var $i : Integer
487-
var $hexValues : Text:="123456789ABCDEF"
487+
var $hexValues : Text:="0123456789ABCDEF"
488488
var $urlLength : Integer:=Length($inURL)
489489
var $result : Text:=""
490490

@@ -577,7 +577,6 @@ Function buildPageFromTemplate($inTitle : Text; $inMessage : Text; $inDetails :
577577
- $inTitle: Title of the page
578578
- $inMessage: Main message to display
579579
- $inDetails: Additional details to display
580-
- $inButtonText: Text for the close button (optional)
581580
*/
582581
var $responseTemplateFile : 4D.File:=Folder(fk resources folder).file("responseTemplate.html")
583582
var $responseTemplateContent : Text:=$responseTemplateFile.getText()

Project/Sources/Classes/URL.4dm

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ Function parseQuery($inQueryString : Text)
155155
// Example: ?query=param&anotherQuery=anotherParam
156156
// Result:
157157
// query: query=param&anotherQuery=anotherParam
158-
// queryParams: [{name: "query"; value: "param"}, {name: "abotherQuery"; value: "anotherParam"}]
158+
// queryParams: [{name: "query"; value: "param"}, {name: "anotherQuery"; value: "anotherParam"}]
159159

160160
var $queryString : Text:=$inQueryString
161161

@@ -167,9 +167,11 @@ Function parseQuery($inQueryString : Text)
167167
var $queryParams : Collection:=Split string($queryString; "&"; sk ignore empty strings)
168168
var $param; $name; $value : Text
169169
For each ($param; $queryParams)
170-
$name:=Substring($param; 1; Position("="; $param)-1)
171-
$value:=Substring($param; Position("="; $param)+1)
172-
This.queryParams.push({name: $name; value: $value})
170+
If (Position("="; $param)>0)
171+
$name:=Substring($param; 1; Position("="; $param)-1)
172+
$value:=Substring($param; Position("="; $param)+1)
173+
This.queryParams.push({name: $name; value: $value})
174+
End if
173175
End for each
174176
End if
175177

Project/Sources/Methods/_authorize.4dm

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,12 @@ If ($URL=$redirectURI)
8787
End if
8888

8989
var $responseFileContent : Text:=$responseFile.getText()
90-
var $outResponseBody : Text:=""
90+
var $responseBody : Text:=""
9191

92-
PROCESS 4D TAGS($responseFileContent; $outResponseBody; $pageTitle; $pageMessage; $pageDetails; $status)
92+
PROCESS 4D TAGS($responseFileContent; $responseBody; $pageTitle; $pageMessage; $pageDetails; $status)
9393

9494
$outResponse.status:=200
95-
$outResponse.body:=$outResponseBody
95+
$outResponse.body:=$responseBody
9696
$outResponse.contentType:="text/html; charset=UTF-8"
9797
Else
9898

0 commit comments

Comments
 (0)