ACI0105889 support option allowInvalidFormula and set it by default to true

When even with option the formula could not be set (same in excel) then set it as text and have a better log in js console

Author: e-marchand

Project/Sources/Classes/workbookOptions.4dm

@@ -218,6 +218,17 @@ Function set allowExtendPasteRange($value : Boolean)
 	This:C1470[""].options.allowExtendPasteRange:=$value
 	VP SET WORKBOOK OPTIONS(This:C1470.area; {allowExtendPasteRange: $value})
 
+		// <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <==
+Function get allowInvalidFormula() : Boolean
+	
+	return This:C1470[""].options.allowInvalidFormula
+	
+	// ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==> ==>
+Function set allowInvalidFormula($value : Boolean)
+
+	This:C1470[""].options.allowInvalidFormula:=$value
+	VP SET WORKBOOK OPTIONS(This:C1470.area; {allowInvalidFormula: $value})
+	
 	// <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <== <==
 Function get allowSheetReorder() : Boolean
 

Resources/schemas/SJS.json

@@ -187,6 +187,10 @@
       "type": "boolean",
       "default": true
     },
+    "allowInvalidFormula": {
+      "type": "boolean",
+      "default": true
+    },
     "referenceStyle": {
       "$ref": "#/definitions/ReferenceStyle",
       "default": 0

Resources/scripts/commands/values.js

@@ -398,11 +398,15 @@
 
                 instancesArray.forEach(i => {
                     const instance = i.sheet.getRange(i.row, i.column, i.rowCount, i.columnCount);
-
-                    instance.formula(params.formula);
-
-                    if (format != null) {
-                        instance.formatter(format);
+                    try {
+                        instance.formula(params.formula);
+                    }
+                    catch(e) {
+                        Utils.logEvent({ type: 'error-catched', data: e, formula: params.formula});
+                        if (Utils.spread.options.allowInvalidFormula == true) {
+                            instance.formula(null);
+                            instance.value("=" + params.formula);
+                        }
                     }
                 });
             });

Resources/scripts/commands/workbook.js

@@ -23,6 +23,7 @@
         'allowCopyPasteExcelStyle',
         'allowDynamicArray',
         'allowExtendPasteRange',
+        'allowInvalidFormula',
         'allowSheetReorder',
         'allowUndo',
         'allowUserDeselect',

Resources/scripts/init.js

@@ -756,6 +756,7 @@ document.addEventListener('DOMContentLoaded', function () {
         // Allow users to enter mathematical formula.
         Utils.spread.options.allowUserEditFormula = true;
         Utils.spread.options.enableFormulaTextbox = true;
+        Utils.spread.options.allowInvalidFormula = true;
 
         if ((vp_localizedFolder !== 'ja.lproj') && (vp_localizedFolder !== 'en.lproj')) {
             let sheetName = vp_spreadJsResources.Sheets.SHEET_NAME;

Resources/scripts/utils.js

@@ -94,18 +94,17 @@ Utils.diagnostics = {
     events: []
 };
 
-Utils.logEvent = function ({ type, data }) {
+Utils.logEvent = function (eventData) {
     if (Utils.diagnostics.events.length >= 500) {
         Utils.diagnostics.events = [];
     }
     const event = {
         time: new Date(),
-        type,
-        data
+        ...eventData
     };
 
     Utils.diagnostics.events.push(event);
-    if (Utils.debug || type.includes("error")) console.log(event);
+    if (Utils.debug || (eventData.type && eventData.type.includes("error"))) console.log(event);
 };
 
 Utils.adjustFormat = function (format) {