fix: Apply review suggestions

Author: MindsMaster

common/src/main/java/io/github/_4drian3d/authmevelocity/common/configuration/ProxyConfiguration.java

@@ -112,13 +112,20 @@ public SendMode sendMode() {
 
     @ConfigSerializable
     public static class Chat {
-        @Comment("Set up users who haven't signed in to send chat that start with the following")
+
+        @Comment("Enable chat filter")
+        private boolean enableAllowedChatPrefixes = false;
+        public boolean enableAllowedChatPrefixes() {
+            return this.enableAllowedChatPrefixes;
+        }
+
+        @Comment("Sets which messages players can send before they have logged in")
         private List<String> allowedChatPrefixes = List.of(".l ", ".reg ", ".email ");
         public List<String> allowedChatPrefixes() {
             return this.allowedChatPrefixes;
         }
 
-        @Comment("Just blocked chat message tip")
+        @Comment("Sets the message to send to players who use messages that are not allowed. \\nLeave this option blank if you do not want the message to be sent.")
         private String blockedChatMessage = "<red>You cannot send this message if you are not logged in yet";
         public String blockedChatMessage() {
             return this.blockedChatMessage;

velocity/src/main/java/io/github/_4drian3d/authmevelocity/velocity/listener/input/ChatListener.java

@@ -27,6 +27,8 @@
 import io.github._4drian3d.authmevelocity.velocity.listener.Listener;
 import net.kyori.adventure.text.minimessage.MiniMessage;
 
+import java.util.List;
+
 public final class ChatListener implements Listener<PlayerChatEvent> {
     @Inject
     private AuthMeVelocityPlugin plugin;
@@ -41,7 +43,6 @@ public void register() {
     @Override
     public EventTask executeAsync(final PlayerChatEvent event) {
         return EventTask.withContinuation(continuation -> {
-            String message = event.getMessage();
             if (plugin.isLogged(event.getPlayer())) {
                 plugin.logDebug(() -> "PlayerChatEvent | Player " + event.getPlayer().getUsername() + " is already logged");
                 continuation.resume();
@@ -50,23 +51,26 @@ public EventTask executeAsync(final PlayerChatEvent event) {
 
             plugin.logDebug(() -> "PlayerChatEvent | Player " + event.getPlayer().getUsername() + " is not logged");
 
-            if (plugin.config().get().chat().allowedChatPrefixes().stream().anyMatch(message::startsWith)) {
-                plugin.logDebug(() -> "PlayerChatEvent | Message \"" + message + "\" is allowed by prefix rule.");
+            if (plugin.config().get().chat().enableAllowedChatPrefixes()
+                    && !plugin.config().get().chat().allowedChatPrefixes().isEmpty()
+                    && isMessageAllowed(event.getMessage(), plugin.config().get().chat().allowedChatPrefixes())) {
+                plugin.logDebug(() -> "PlayerChatEvent | Allowed message: " + event.getMessage());
                 continuation.resume();
                 return;
             }
 
-            plugin.logDebug(() -> "PlayerChatEvent | Message \"" + message + "\" is blocked.");
-            sendBlockedChatMessage(event.getPlayer());
+            plugin.logDebug(() -> "PlayerChatEvent | Blocked message: " + event.getMessage());
             event.setResult(PlayerChatEvent.ChatResult.denied());
             continuation.resume();
         });
     }
 
-    private void sendBlockedChatMessage(final Player player){
-        final String blockedChatMessage = plugin.config().get().chat().blockedChatMessage();
-        if (!blockedChatMessage.isBlank()){
-            player.sendMessage(MiniMessage.miniMessage().deserialize(blockedChatMessage));
+    private boolean isMessageAllowed(String message, List<String> allowedPrefixes) {
+        for (String prefix : allowedPrefixes) {
+            if (message.startsWith(prefix)) {
+                return true;
+            }
         }
+        return false;
     }
 }