Fix endless reloads of in-game editor on Windows due to autosave

Also fix ignored files watching on Windows

Author: 4ian

newIDE/app/src/ExportAndShare/BrowserExporters/BrowserS3PreviewLauncher/index.js

@@ -194,7 +194,10 @@ export default class BrowserS3PreviewLauncher extends React.Component<
           previewOptions.authenticatedPlayer.playerToken
         );
       }
-      if (previewOptions.captureOptions.screenshots) {
+      if (
+        previewOptions.captureOptions &&
+        previewOptions.captureOptions.screenshots
+      ) {
         previewOptions.captureOptions.screenshots.forEach(screenshot => {
           previewExportOptions.addScreenshotCapture(
             screenshot.delayTimeInSeconds,

newIDE/app/src/ExportAndShare/BrowserExporters/BrowserSWPreviewLauncher/index.js

@@ -232,7 +232,10 @@ export default class BrowserSWPreviewLauncher extends React.Component<
           previewOptions.authenticatedPlayer.playerToken
         );
       }
-      if (previewOptions.captureOptions.screenshots) {
+      if (
+        previewOptions.captureOptions &&
+        previewOptions.captureOptions.screenshots
+      ) {
         previewOptions.captureOptions.screenshots.forEach(screenshot => {
           previewExportOptions.addScreenshotCapture(
             screenshot.delayTimeInSeconds,

newIDE/app/src/ExportAndShare/PreviewLauncher.flow.js

@@ -63,7 +63,7 @@ export type PreviewOptions = {|
   editorId: string,
   getIsMenuBarHiddenInPreview: () => boolean,
   getIsAlwaysOnTopInPreview: () => boolean,
-  captureOptions: CaptureOptions,
+  captureOptions: CaptureOptions | null,
   onCaptureFinished: CaptureOptions => Promise<void>,
   inAppTutorialMessageInPreview: string,
   inAppTutorialMessagePositionInPreview: string,

newIDE/app/src/MainFrame/index.js

@@ -2182,9 +2182,11 @@ const MainFrame = (props: Props) => {
         ? previewState.overridenPreviewExternalLayoutName
         : previewState.previewExternalLayoutName;
 
-      autosaveProjectIfNeeded().catch(err => {
-        console.error('Error while auto-saving the project. Ignoring.', err);
-      });
+      if (!isForInGameEdition) {
+        autosaveProjectIfNeeded().catch(err => {
+          console.error('Error while auto-saving the project. Ignoring.', err);
+        });
+      }
 
       // Note that in the future, this kind of checks could be done
       // and stored in a "diagnostic report", rather than hiding errors
@@ -2198,11 +2200,12 @@ const MainFrame = (props: Props) => {
           }
         : null;
 
-      const authenticatedPlayer = await getAuthenticatedPlayerForPreview();
-
-      const captureOptions = await createCaptureOptionsForPreview(
-        launchCaptureOptions
-      );
+      const [authenticatedPlayer, captureOptions] = await Promise.all([
+        isForInGameEdition ? null : getAuthenticatedPlayerForPreview(),
+        isForInGameEdition
+          ? null
+          : createCaptureOptionsForPreview(launchCaptureOptions),
+      ]);
 
       try {
         await eventsFunctionsExtensionsState.ensureLoadFinished();

newIDE/app/src/ProjectsStorage/LocalFileStorageProvider/LocalFileResourcesWatcher.js

@@ -48,6 +48,9 @@ export const setupResourcesWatcher =
           // never ending.
           debouncedCallback(path);
         });
+
+        // Note: this ignore list is not a list of glob. Any file that matches a string in this list will be ignored.
+        // This could be improved to separate this in a list of paths, filenames, etc.
         const ignore = [
           path.sep + '.DS_Store', // macOS folder attributes file
           path.sep + '.git', // For projects using git as a versioning tool.
@@ -58,7 +61,7 @@ export const setupResourcesWatcher =
         if (options && options.isProjectSplitInMultipleFiles) {
           ignore.push(
             ...splittedProjectFolderNames.map(folderName =>
-              path.join(folderPath, folderName, '*.json')
+              path.join(folderPath, folderName)
             )
           );
         }

newIDE/electron-app/app/LocalFilesystemWatcher.js

@@ -10,24 +10,35 @@ const getNewSubscriptionId = () => {
   return id.toString();
 };
 
+const normalizePath = path => {
+  if (!path) return ''; // Safety check
+
+  return path.replace(/\\/g, '/');
+};
+
 const setupWatcher = (folderPath, fileWiseCallback, serializedOptions) => {
   const options = JSON.parse(serializedOptions);
   const newSubscriptionId = getNewSubscriptionId();
   const watcher = fileWatcher
     .watch(folderPath, {
       ignored: candidatePath => {
+        // Normalize the path to avoid issues with different path separators (\ on Windows, / on other OSes).
+        // Even on Windows, "candidatePath" returned by chokidar is always using "/".
+        // So we normalize all paths (candidatePath and ignore paths) to avoid missing ignored files on Windows.
+        const normalizedCandidatePath = normalizePath(candidatePath);
+
         if (
           (options.ignore || []).some(ignore =>
-            candidatePath.includes(ignore)
+            normalizedCandidatePath.includes(normalizePath(ignore))
           ) ||
           // Force ignore, for safety, any node_modules folder as they are too big and would crash the watcher on macOS.
           // Note that this will ignore any folder whose name is prefixed by "node_modules".
-          candidatePath.includes(path.sep + 'node_modules') ||
+          normalizedCandidatePath.includes('/node_modules') ||
           // Same for git repositories (and any file starting by ".git").
-          candidatePath.includes(path.sep + '.git')
+          normalizedCandidatePath.includes('/.git')
         ) {
           console.info(
-            `Local file watcher has ignored path "${candidatePath}".`
+            `Local file watcher has ignored path "${normalizedCandidatePath}".`
           );
           return true;
         }