Fix shortcut to rename a layer

Author: ClementPasteau

newIDE/app/src/LayersList/LayerTreeViewItemContent.js

@@ -149,7 +149,7 @@ export class LayerTreeViewItemContent implements TreeViewItemContent {
     return [
       {
         label: i18n._(t`Rename`),
-        click: () => this.props.editName(this.layer.getName()),
+        click: () => this.props.editName(this.getId()),
         accelerator: 'F2',
         enabled: !this._isBaseLayer(),
       },

newIDE/app/src/LayersList/index.js

@@ -336,14 +336,13 @@ const LayersList = React.forwardRef<Props, LayersListInterface>(
     }));
 
     const editName = React.useCallback(
-      (layerName: string) => {
-        // Don't allow renaming base layer (empty name)
-        if (!layerName) return;
-
-        if (!layersContainer.hasLayerNamed(layerName)) return;
-        const layer = layersContainer.getLayer(layerName);
+      (itemId: string) => {
+        // Don't allow renaming the base layer (empty name). The base layer is
+        // always accessible by its empty name, so we can compare item IDs directly.
+        if (itemId === getLayerTreeViewItemId(layersContainer.getLayer(''))) {
+          return;
+        }
 
-        const itemId = getLayerTreeViewItemId(layer);
         const treeView = treeViewRef.current;
         if (treeView) {
           if (isMobile) {