Address review feedback on persisted scroll and editor state

Author: 4ian

newIDE/app/src/InstancesEditor/CompactInstancePropertiesEditor/index.js

@@ -170,19 +170,19 @@ export const CompactInstancePropertiesEditor = ({
     .map((instance: gdInitialInstance) => '' + instance.ptr)
     .join(';');
 
-  const selectedObjectForScroll = React.useMemo(() => {
+  const persistedScrollId = React.useMemo(() => {
     if (!instances.length) return null;
 
-    return getObjectByName(
+    const selectedObjectForScroll = getObjectByName(
       globalObjectsContainer,
       objectsContainer,
       instances[0].getObjectName()
     );
-  }, [globalObjectsContainer, instances, objectsContainer]);
 
-  const persistedScrollId = selectedObjectForScroll
-    ? selectedObjectForScroll.getPersistentUuid()
-    : null;
+    return selectedObjectForScroll
+      ? selectedObjectForScroll.getPersistentUuid()
+      : null;
+  }, [globalObjectsContainer, instances, objectsContainer]);
 
   const onScroll = usePersistedScrollPosition({
     project,

newIDE/app/src/MainFrame/Preferences/PreferencesProvider.js

@@ -1281,14 +1281,7 @@ export default class PreferencesProvider extends React.Component<Props, State> {
             ...editorState,
           };
 
-          if (
-            mergedEditorState.editorTabs === null &&
-            Object.keys(mergedEditorState.propertiesPanelScroll).length === 0
-          ) {
-            delete nextEditorStateByProject[projectId];
-          } else {
-            nextEditorStateByProject[projectId] = mergedEditorState;
-          }
+          nextEditorStateByProject[projectId] = mergedEditorState;
         }
 
         return {