Fix MarkdownText using a div instead of a span when not a standalone text

* Also add a missing translation
* Also enable player authentication by default when creating a new game

Author: 4ian

newIDE/app/src/GameDashboard/LeaderboardAdmin/LeaderboardSortOptionsDialog.js

@@ -165,8 +165,8 @@ function LeaderboardSortOptionsDialog({
                     <MarkdownText
                       source={i18n._(
                         sortOrder === 'ASC'
-                          ? `Any submitted score that is lower than the set value will not be saved in the leaderboard.`
-                          : `Any submitted score that is higher than the set value will not be saved in the leaderboard.`
+                          ? t`Any submitted score that is lower than the set value will not be saved in the leaderboard.`
+                          : t`Any submitted score that is higher than the set value will not be saved in the leaderboard.`
                       )}
                     />
                   </FormHelperText>

newIDE/app/src/ProjectCreation/NewProjectSetupDialog.js

@@ -18,7 +18,7 @@ import SelectField from '../UI/SelectField';
 import SelectOption from '../UI/SelectOption';
 import CreateProfile from '../Profile/CreateProfile';
 import Paper from '../UI/Paper';
-import { Line, Spacer } from '../UI/Grid';
+import { Line } from '../UI/Grid';
 import LeftLoader from '../UI/LeftLoader';
 import {
   checkIfHasTooManyCloudProjects,
@@ -28,8 +28,7 @@ import { SubscriptionSuggestionContext } from '../Profile/Subscription/Subscript
 import optionalRequire from '../Utils/OptionalRequire';
 import PreferencesContext from '../MainFrame/Preferences/PreferencesContext';
 import Checkbox from '../UI/Checkbox';
-import Link from '../UI/Link';
-import Window from '../Utils/Window';
+import { MarkdownText } from '../UI/MarkdownText';
 
 const electron = optionalRequire('electron');
 const remote = optionalRequire('@electron/remote');
@@ -109,7 +108,7 @@ const NewProjectSetupDialog = ({
     false
   );
   const [allowPlayersToLogIn, setAllowPlayersToLogIn] = React.useState<boolean>(
-    false
+    true
   );
   const newProjectsDefaultFolder = app
     ? findEmptyPathInWorkspaceFolder(app, values.newProjectsDefaultFolder || '')
@@ -347,21 +346,9 @@ const NewProjectSetupDialog = ({
               }}
               disabled={isOpening}
               tooltipOrHelperText={
-                <Line noMargin>
-                  <Trans>Learn more about</Trans>
-                  <Spacer />
-                  <Link
-                    href="https://wiki.gdevelop.io/gdevelop5/all-features/player-authentication"
-                    onClick={() =>
-                      Window.openExternalURL(
-                        'https://wiki.gdevelop.io/gdevelop5/all-features/player-authentication'
-                      )
-                    }
-                  >
-                    <Trans>player authentication</Trans>
-                  </Link>
-                  .
-                </Line>
+                <MarkdownText
+                  translatableSource={t`Learn more about [player authentication](https://wiki.gdevelop.io/gdevelop5/all-features/player-authentication).`}
+                />
               }
             />
           </ColumnStackLayout>

newIDE/app/src/UI/MarkdownText.js

@@ -11,7 +11,6 @@ const makeMarkdownCustomComponents = (
   isStandaloneText: boolean,
   allowParagraphs: boolean
 ) => ({
-  '**': props => (isStandaloneText ? <div {...props} /> : <span {...props} />),
   // Ensure link are opened in a new page
   a: props =>
     props.href ? (
@@ -51,22 +50,27 @@ export const MarkdownText = (props: Props) => {
     [props.isStandaloneText, props.allowParagraphs]
   );
 
-  return (
+  const markdownElement = (
     <I18n>
       {({ i18n }) => (
-        <ReactMarkdown
-          className={classNames({
-            'gd-markdown': true,
-            [gdevelopTheme.markdownRootClassName]: true,
-            'standalone-text-container': props.isStandaloneText,
-          })}
-          components={markdownCustomComponents}
-        >
+        <ReactMarkdown components={markdownCustomComponents}>
           {props.translatableSource
             ? i18n._(props.translatableSource)
             : props.source}
         </ReactMarkdown>
       )}
     </I18n>
   );
+
+  const className = classNames({
+    'gd-markdown': true,
+    [gdevelopTheme.markdownRootClassName]: true,
+    'standalone-text-container': props.isStandaloneText,
+  });
+
+  return props.isStandaloneText ? (
+    <div className={className}>{markdownElement}</div>
+  ) : (
+    <span className={className}>{markdownElement}</span>
+  );
 };

newIDE/app/yarn.lock

@@ -5154,6 +5154,13 @@
     "buffers" "~0.1.1"
     "chainsaw" "~0.1.0"
 
+"bindings@^1.5.0":
+  "integrity" "sha512-p2q/t/mhvuOj/UeLlV6566GD/guowlr0hHxClI0W9m7MWYkL1F0hLo+0Aexs9HSPCtR1SXQ0TD3MMKrXZajbiQ=="
+  "resolved" "https://registry.npmjs.org/bindings/-/bindings-1.5.0.tgz"
+  "version" "1.5.0"
+  dependencies:
+    "file-uri-to-path" "1.0.0"
+
 "bluebird@^3.3.5", "bluebird@^3.5.5":
   "integrity" "sha512-XpNj6GDQzdfW+r2Wnn7xiSAd7TM3jzkxGXBGTtWKuSXv1xUV+azxAm8jdWZN06QTQk+2N2XB9jRDkvbmQmcRtg=="
   "resolved" "https://registry.npmjs.org/bluebird/-/bluebird-3.7.2.tgz"
@@ -8799,6 +8806,19 @@
   "resolved" "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz"
   "version" "1.0.0"
 
+"fsevents@^1.2.7":
+  "integrity" "sha512-oWb1Z6mkHIskLzEJ/XWX0srkpkTQ7vaopMQkyaEIoq0fmtFVxOthb8cCxeT+p3ynTdkk/RZwbgG4brR5BeWECw=="
+  "resolved" "https://registry.npmjs.org/fsevents/-/fsevents-1.2.13.tgz"
+  "version" "1.2.13"
+  dependencies:
+    "bindings" "^1.5.0"
+    "nan" "^2.12.1"
+
+"fsevents@^2.1.2", "fsevents@^2.1.3", "fsevents@~2.3.2":
+  "integrity" "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA=="
+  "resolved" "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz"
+  "version" "2.3.2"
+
 "fstream@^1.0.12":
   "integrity" "sha512-WvJ193OHa0GHPEL+AycEJgxvBEwyfRkN1vhjca23OaPVMCaLCXTd5qAu82AjTcgP1UJmytkOKb63Ypde7raDIg=="
   "resolved" "https://registry.npmjs.org/fstream/-/fstream-1.0.12.tgz"
@@ -12222,6 +12242,11 @@
   "resolved" "https://registry.npmjs.org/mute-stream/-/mute-stream-0.0.7.tgz"
   "version" "0.0.7"
 
+"nan@^2.12.1":
+  "integrity" "sha512-isWHgVjnFjh2x2yuJ/tj3JbwoHu3UC2dX5G/88Cm24yB6YopVgxvBObDY7n5xW6ExmFhJpSEQqFPvq9zaXc8Jw=="
+  "resolved" "https://registry.npmjs.org/nan/-/nan-2.14.1.tgz"
+  "version" "2.14.1"
+
 "nanoid@^3.3.3":
   "integrity" "sha512-MqBkQh/OHTS2egovRtLk45wEyNXwF+cokD+1YPf9u5VfJiRdAiRwB2froX5Co9Rh20xs4siNPm8naNotSD6RBw=="
   "resolved" "https://registry.npmjs.org/nanoid/-/nanoid-3.3.4.tgz"