Add types to various low-level functions (go-gitea#31781)

Adds types to various low-level modules. All changes are type-only, no
runtime changes. `tsc` now reports 38 less errors.

One problem was that `@types/sortablejs` does not accept promise return
in its functions which triggered the linter, so I disabled the rules on
those line.

Author: silverwind

package-lock.json

@@ -107,6 +107,7 @@
     "stylelint-declaration-strict-value": "1.10.6",
     "stylelint-value-no-unknown-custom-properties": "6.0.1",
     "svgo": "3.3.2",
+    "type-fest": "4.23.0",
     "updates": "16.3.7",
     "vite-string-plugin": "1.3.4",
     "vitest": "2.0.5"

package.json

@@ -3,6 +3,11 @@ declare module '*.svg' {
   export default value;
 }
 
+declare module '*.css' {
+  const value: string;
+  export default value;
+}
+
 declare let __webpack_public_path__: string;
 
 interface Window {
@@ -20,3 +25,7 @@ declare module 'htmx.org/dist/htmx.esm.js' {
   const value = await import('htmx.org');
   export default value;
 }
+
+interface Element {
+  _tippy: import('tippy.js').Instance;
+}

types.d.ts

@@ -52,7 +52,7 @@ function addCopyLink(file) {
   copyLinkEl.addEventListener('click', async (e) => {
     e.preventDefault();
     const success = await clippie(generateMarkdownLinkForAttachment(file));
-    showTemporaryTooltip(e.target, success ? i18n.copy_success : i18n.copy_error);
+    showTemporaryTooltip(e.target as Element, success ? i18n.copy_success : i18n.copy_error);
   });
   file.previewTemplate.append(copyLinkEl);
 }

web_src/js/features/dropzone.ts

@@ -196,7 +196,7 @@ async function initIssuePinSort() {
 
   createSortable(pinDiv, {
     group: 'shared',
-    onEnd: pinMoveEnd,
+    onEnd: pinMoveEnd, // eslint-disable-line @typescript-eslint/no-misused-promises
   });
 }
 

web_src/js/features/repo-issue-list.ts

@@ -60,7 +60,7 @@ async function initRepoProjectSortable() {
     handle: '.project-column-header',
     delayOnTouchOnly: true,
     delay: 500,
-    onSort: async () => {
+    onSort: async () => { // eslint-disable-line @typescript-eslint/no-misused-promises
       boardColumns = mainBoard.querySelectorAll('.project-column');
 
       const columnSorting = {
@@ -84,8 +84,8 @@ async function initRepoProjectSortable() {
     const boardCardList = boardColumn.querySelectorAll('.cards')[0];
     createSortable(boardCardList, {
       group: 'shared',
-      onAdd: moveIssue,
-      onUpdate: moveIssue,
+      onAdd: moveIssue, // eslint-disable-line @typescript-eslint/no-misused-promises
+      onUpdate: moveIssue, // eslint-disable-line @typescript-eslint/no-misused-promises
       delayOnTouchOnly: true,
       delay: 500,
     });

web_src/js/features/repo-projects.ts

@@ -27,7 +27,7 @@ export function initStopwatch() {
     stopwatchEl.removeAttribute('href'); // intended for noscript mode only
 
     createTippy(stopwatchEl, {
-      content: stopwatchPopup.cloneNode(true),
+      content: stopwatchPopup.cloneNode(true) as Element,
       placement: 'bottom-end',
       trigger: 'click',
       maxWidth: 'none',

web_src/js/features/stopwatch.ts

@@ -1,7 +1,9 @@
 import {isDocumentFragmentOrElementNode} from '../utils/dom.ts';
 
+type DirElement = HTMLInputElement | HTMLTextAreaElement;
+
 // for performance considerations, it only uses performant syntax
-function attachDirAuto(el) {
+function attachDirAuto(el: DirElement) {
   if (el.type !== 'hidden' &&
       el.type !== 'checkbox' &&
       el.type !== 'radio' &&
@@ -18,10 +20,12 @@ export function initDirAuto() {
       const mutation = mutationList[i];
       const len = mutation.addedNodes.length;
       for (let i = 0; i < len; i++) {
-        const addedNode = mutation.addedNodes[i];
+        const addedNode = mutation.addedNodes[i] as HTMLElement;
         if (!isDocumentFragmentOrElementNode(addedNode)) continue;
-        if (addedNode.nodeName === 'INPUT' || addedNode.nodeName === 'TEXTAREA') attachDirAuto(addedNode);
-        const children = addedNode.querySelectorAll('input, textarea');
+        if (addedNode.nodeName === 'INPUT' || addedNode.nodeName === 'TEXTAREA') {
+          attachDirAuto(addedNode as DirElement);
+        }
+        const children = addedNode.querySelectorAll<DirElement>('input, textarea');
         const len = children.length;
         for (let childIdx = 0; childIdx < len; childIdx++) {
           attachDirAuto(children[childIdx]);
@@ -30,7 +34,7 @@ export function initDirAuto() {
     }
   });
 
-  const docNodes = document.querySelectorAll('input, textarea');
+  const docNodes = document.querySelectorAll<DirElement>('input, textarea');
   const len = docNodes.length;
   for (let i = 0; i < len; i++) {
     attachDirAuto(docNodes[i]);

web_src/js/modules/dirauto.ts

@@ -1,4 +1,6 @@
-export async function createSortable(el, opts = {}) {
+import type {SortableOptions} from 'sortablejs';
+
+export async function createSortable(el, opts: {handle?: string} & SortableOptions = {}) {
   const {Sortable} = await import(/* webpackChunkName: "sortablejs" */'sortablejs');
 
   return new Sortable(el, {
@@ -15,5 +17,5 @@ export async function createSortable(el, opts = {}) {
       opts.onUnchoose?.(e);
     },
     ...opts,
-  });
+  } satisfies SortableOptions);
 }

web_src/js/modules/sortable.ts

@@ -1,6 +1,7 @@
 import {reactive} from 'vue';
+import type {Reactive} from 'vue';
 
-let diffTreeStoreReactive;
+let diffTreeStoreReactive: Reactive<Record<string, any>>;
 export function diffTreeStore() {
   if (!diffTreeStoreReactive) {
     diffTreeStoreReactive = reactive(window.config.pageData.diffFileInfo);