Skip to content

Commit 3220e48

Browse files
fix(value-objects): pass unit tests using hasLengthBetween insteadof hasLengthBetweenOrEqual
1 parent a7904c9 commit 3220e48

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

lib/utils/password.value-object.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,7 @@ class PasswordValueObject extends ValueObject<Prop> {
9797
public static isValidProps(value: string): boolean {
9898
const { string } = this.validator;
9999
if (!PasswordValueObject.isEncrypted(value)) {
100-
const passwordHasRequiredLength = string(
101-
value
102-
).hasLengthBetweenOrEqual(
100+
const passwordHasRequiredLength = string(value).hasLengthBetween(
103101
PasswordValueObject.MIN_LENGTH,
104102
PasswordValueObject.MAX_LENGTH
105103
);

lib/utils/url.value-object.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { ValueObject } from '../core';
22
import { Result } from '../core';
33
const regexHash =
4-
/^(https?:\/\/)?(([\da-z\.-]+))?\.?([a-z\.]{2,6})([\/\w \.-]*)*\/?(:\d{2,4})?(\/\w+)?$/;
4+
/^(https?:\/\/)(([\da-z\.-]+))?\.?([a-z\.]{2,6})([\/\w \.-]*)*\/?(:\d{2,4})?(\/\w+)?$/;
55

66
interface Prop {
77
value: string;

lib/utils/user-name.value-object.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export class UserNameValueObject extends ValueObject<Prop> {
109109
*/
110110
public static isValidProps(value: string): boolean {
111111
const { string } = this.validator;
112-
return string(value).hasLengthBetweenOrEqual(
112+
return string(value).hasLengthBetween(
113113
UserNameValueObject.MIN_LENGTH,
114114
UserNameValueObject.MAX_LENGTH
115115
);

0 commit comments

Comments
 (0)