fix: ensure tests from pull request

fix
#222

Author: 4lessandrodev

CHANGELOG.md

@@ -4,6 +4,19 @@ All notable changes to this project will be documented in this file.
 
 ## Unreleased
 
+
+---
+
+### [3.5.2] - 2023-02-18
+
+### Changed
+
+- validation to `url.value-object` use URL default validation and remove regex. by @ArturHamannRonconi
+
+### Added 
+
+- added separator as optional param to `getInitials`method from `user-name.value-object`
+
 ---
 ### [3.5.1] - 2023-01-27
 

lib/utils/cpf.value-object.ts

@@ -1,9 +1,7 @@
 import { ValueObject } from '../core';
 import { Result } from '../core';
-import isValidCpfDigit, {
-	formatValueToCpfPattern,
-	removeSpecialCharsFromCpf,
-} from './check-cpf-digit.util';
+import isValidCpfDigit from './check-cpf-digit.util';
+import { formatValueToCpfPattern } from './check-cpf-digit.util';
 const regexCpf =
 	/^([0-9]{3})[\.]((?!\1)[0-9]{3})[\.]([0-9]{3})[-]([0-9]{2})$|^[0-9]{11}$/;
 
@@ -36,11 +34,9 @@ export class CPFValueObject extends ValueObject<Prop> {
 	 * @example after "52734865211"
 	 */
 	removeSpecialChars(): CPFValueObject {
-		this.props.value = removeSpecialCharsFromCpf(this.props.value);
-
-		// this.props.value = this.util
-		// 	.string(this.props.value)
-		// 	.removeSpecialChars();
+		this.props.value = this.util
+			.string(this.props.value)
+			.removeSpecialChars();
 		return this;
 	}
 
@@ -62,13 +58,10 @@ export class CPFValueObject extends ValueObject<Prop> {
 	 * @example param "527.348.652-11"
 	 */
 	compare(cpf: string): boolean {
-		// const formattedCpf = this.util.string(cpf).removeSpecialChars();
-		// const instanceValue = this.util
-		// 	.string(this.props.value)
-		// 	.removeSpecialChars();
-
-		const formattedCpf = removeSpecialCharsFromCpf(cpf);
-		const instanceValue = removeSpecialCharsFromCpf(this.props.value);
+		const formattedCpf = this.util.string(cpf).removeSpecialChars();
+		const instanceValue = this.util
+			.string(this.props.value)
+			.removeSpecialChars();
 		return instanceValue === formattedCpf;
 	}
 

lib/utils/password.value-object.ts

@@ -97,7 +97,9 @@ class PasswordValueObject extends ValueObject<Prop> {
 	public static isValidProps(value: string): boolean {
 		const { string } = this.validator;
 		if (!PasswordValueObject.isEncrypted(value)) {
-			const passwordHasRequiredLength = string(value).hasLengthBetween(
+			const passwordHasRequiredLength = string(
+				value
+			).hasLengthBetweenOrEqual(
 				PasswordValueObject.MIN_LENGTH,
 				PasswordValueObject.MAX_LENGTH
 			);
@@ -106,7 +108,7 @@ class PasswordValueObject extends ValueObject<Prop> {
 		return true;
 	}
 
-	isEqual(password: PasswordValueObject) {
+	isEqual(password: PasswordValueObject): boolean {
 		return this.compare(password.value());
 	}
 

lib/utils/url.value-object.ts

@@ -1,14 +1,11 @@
 import { ValueObject } from '../core';
 import { Result } from '../core';
-const regexHash =
-	/^(https?:\/\/)(([\da-z\.-]+))?\.?([a-z\.]{2,6})([\/\w \.-]*)*\/?(:\d{2,4})?(\/\w+)?$/;
 
 interface Prop {
 	value: string;
 }
 
 class UrlValueObject extends ValueObject<Prop> {
-	protected static readonly REGEX = regexHash;
 	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid url value';
 
@@ -38,6 +35,10 @@ class UrlValueObject extends ValueObject<Prop> {
 		}
 	}
 
+	public URL(): URL {
+		return new URL(this.props.value);
+	}
+
 	validation(value: string): boolean {
 		return UrlValueObject.isValidProps(value);
 	}

lib/utils/user-name.value-object.ts

@@ -28,7 +28,7 @@ export class UserNameValueObject extends ValueObject<Prop> {
 	 * @returns instance
 	 */
 	private capitalize(): UserNameValueObject {
-		const names = this.props.value.split(' ').filter((name) => {
+		const names = this.props.value.split(' ').filter((name): boolean => {
 			return name.length > 1;
 		});
 
@@ -39,12 +39,10 @@ export class UserNameValueObject extends ValueObject<Prop> {
 			capitalized.push(lowerCaseName);
 		}
 
-		// const value = this.util
-		// 	.string(capitalized.toString())
-		// 	.replace(',')
-		// 	.to(' ');
-
-		const value = capitalized.toString().replace(/,/g, ' ');
+		const value = this.util
+			.string(capitalized.toString())
+			.replace(',')
+			.to(' ');
 
 		this.props.value = value;
 		return this;
@@ -96,19 +94,17 @@ export class UserNameValueObject extends ValueObject<Prop> {
 
 	/**
 	 * @returns initials as string
+	 * @param separator as string char to separate letters
+	 * @default separator . (dot)
 	 * @example
 	 * for a name "Thomas A. Anderson" = "T.A.A"
 	 */
-	getInitials(): string {
+	getInitials(separator = '.'): string {
 		const names = this.props.value.split(' ');
 		const letters = names.map((name) => name[0]);
+		const value = this.util.string(letters.toString());
 
-		// const initials = this.
-		// 	.string(letters.toString())
-		// 	.replace(',')
-		// 	.to('.');
-
-		const initials = letters.toString().replace(/,/g, '.');
+		const initials = value.replace(',').to(separator);
 
 		return initials;
 	}

package.json

@@ -60,7 +60,7 @@
 	"dependencies": {
 		"bcrypt": "^5.0.1",
 		"pino": "^8.8.0",
-		"pino-pretty": "^9.1.1",
+		"pino-pretty": "^9.3.0",
 		"rich-domain": "^1.17.1"
 	},
 	"devDependencies": {

tests/utils/password.value-object.spec.ts

@@ -76,7 +76,8 @@ describe('password.value-object', () => {
 
 		it('should password to be equal', () => {
 			const passA = PasswordValueObject.create('123456abc!').value();
-			const passB = PasswordValueObject.create('123456abc!').value();
+			/**  @todo: fix inference type on clone to get instance type */
+			const passB = passA.clone() as PasswordValueObject;
 			const isEqual = passA.isEqual(passB);
 			expect(isEqual).toBe(true);
 		});

tests/utils/user-name-value-object.util.spec.ts

@@ -117,6 +117,20 @@ describe('user-name.value-object', () => {
 		expect(username.getInitials()).toBe('F.M.L');
 	});
 
+	it('should get initials with custom separator', () => {
+		const separator = '-';
+		const username =
+			UserNameValueObject.create('FIRST MIDDLE LAST').value();
+		expect(username.getInitials(separator)).toBe('F-M-L');
+	});
+
+	it('should get initials with none separator', () => {
+		const separator = '';
+		const username =
+			UserNameValueObject.create('FIRST MIDDLE LAST').value();
+		expect(username.getInitials(separator)).toBe('FML');
+	});
+
 	it('should get initials', () => {
 		const username = UserNameValueObject.create('FIRSt').value();
 		expect(username.getInitials()).toBe('F');