Regex for amazon-ami data source filter comments out part of the code

[feyzee]

Plugin is commenting out part of the code when it encounters the string - '/*'.

I'm using filters for data source amazon-ami to get an ubuntu image. Value for name key in the filter is "ubuntu/images/ubuntu-bionic-18.04-amd64-server-".

images/*ubuntu

Above part is the problematic one, as plugin assumes it is a comment. Following code is from Packer docs and valid. Tested using validate and build subcommands in Packer.

data "amazon-ami" "ubuntu" {
	filters = {
		virtualization-type = "hvm"
		name = "ubuntu/images/*ubuntu-bionic-18.04-amd64-server-*"
		root-device-type = "ebs"
	}
	owners = ["099720109477"]
        most_recent = true
	profile = var.aws_profile
	region = var.region
}

Here's a screenshot of the code above code.

And without "/*" part

[comerford]

can confirm, have the same issue - HCL allows you to create a comment block with:

/* comment1
comment2
*/
var abc = int 0

The fix would be something like ignoring this pattern inside string quotes (single or double) but I have no idea how to make that the case in the grammar format used here. For now I am putting the data block for the amazon ami at the bottom of the config to limit the impact of the highlighting issue, or put the search string for the name in a variable and reference that instead.

[triti]

put the search string for the name in a variable and reference that instead

Additionally... You have to use a variable (probably with a hardcoded default value) and not a local as datasources cannot currently reference locals in Packer (as of 1.7.3). Reference: hashicorp/packer#11011