fix: fix compile warnings (#4038)

DSFans2014 · web-flow · commit 19df26b75652 · 2025-08-14T13:04:27.000+08:00
diff --git a/hybridse/include/base/fe_status.h b/hybridse/include/base/fe_status.h
@@ -27,16 +27,9 @@ namespace hybridse {
 namespace base {
 
 template <typename STREAM, typename... Args>
-static inline std::initializer_list<int> __output_literal_args(STREAM& stream,  // NOLINT
-                                                               Args... args) {  // NOLINT
-#ifdef __APPLE__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wreturn-stack-address"
-#endif
-    return std::initializer_list<int>{(stream << args, 0)...};
-#ifdef __APPLE__
-#pragma GCC diagnostic pop
-#endif
+static inline void __output_literal_args(STREAM& stream,  // NOLINT
+                                         Args... args) {  // NOLINT
+    ((stream << args), ...);
 }
 
 #define MAX_STATUS_TRACE_SIZE 4096
diff --git a/hybridse/include/vm/engine.h b/hybridse/include/vm/engine.h
@@ -256,7 +256,7 @@ class RequestRunSession : public RunSession {
     /// \param in_row: request row
     /// \param[out] output: result is written to this variable
     /// \return `0` if run successfully else negative integer
-    int32_t Run(uint32_t task_id, const Row& in_row, Row* output);  // NOLINT
+    int32_t Run(int32_t task_id, const Row& in_row, Row* output);  // NOLINT
 
     /// \brief Return the schema of request row
     virtual const Schema& GetRequestSchema() const {
@@ -303,7 +303,7 @@ class BatchRequestRunSession : public RunSession {
     /// \param request_batch: a batch of request rows
     /// \param output: query results will be returned as std::vector<Row> in output
     /// \return 0 if runs successfully else negative integer
-    int32_t Run(const uint32_t id, const std::vector<Row>& request_batch, std::vector<Row>& output);  // NOLINT
+    int32_t Run(int32_t id, const std::vector<Row>& request_batch, std::vector<Row>& output);  // NOLINT
 
     /// \brief Add common column idx
     void AddCommonColumnIdx(size_t idx) { common_column_indices_.insert(idx); }
diff --git a/hybridse/src/base/fe_linenoise.cc b/hybridse/src/base/fe_linenoise.cc
@@ -539,7 +539,9 @@ static void refreshSingleLine(struct linenoiseState *l) {
     /* Move cursor to original position. */
     snprintf(seq, sizeof(seq), "\r\x1b[%dC", static_cast<int>(pos + plen));
     abAppend(&ab, seq, strlen(seq));
-    write(fd, ab.b, ab.len);
+    if (write(fd, ab.b, ab.len) == -1) {
+        perror("terminal write failed");
+    }
     /* Can't recover from write error. */
     abFree(&ab);
 }
@@ -627,7 +629,9 @@ static void refreshMultiLine(struct linenoiseState *l) {
     lndebug("\n");
     l->oldpos = l->pos;
 
-    write(fd, ab.b, ab.len); /* Can't recover from write error. */
+    if (write(fd, ab.b, ab.len) == -1) { /* Can't recover from write error. */
+        perror("terminal write failed");
+    }
     abFree(&ab);
 }
 
diff --git a/hybridse/src/codec/fe_row_codec.cc b/hybridse/src/codec/fe_row_codec.cc
@@ -1166,7 +1166,7 @@ base::Status RowBuilder2::Build(const std::vector<node::ExprNode*>& values, code
 
     auto expect_cols =
         std::accumulate(schemas_.begin(), schemas_.end(), 0, [](int val, const auto& e) { return val + e.size(); });
-    CHECK_TRUE(values.size() == expect_cols, common::kCodegenEncodeError, "pass in expr number do not match, expect ",
+    CHECK_TRUE(values.size() == static_cast<size_t>(expect_cols), common::kCodegenEncodeError, "pass in expr number do not match, expect ",
                expect_cols, " but got ", values.size(), ": (",
                absl::StrJoin(
                    values, ", ",
@@ -1193,7 +1193,7 @@ base::Status RowBuilder2::Build(const std::vector<node::ExprNode*>& values, code
     return {};
 }
 base::Status RowBuilder2::InitSchema(int idx, const codec::Schema& sc) {
-    if (idx >= schemas_.size()) {
+    if (static_cast<size_t>(idx) >= schemas_.size()) {
         return {common::kCodegenEncodeError, "idx out of bound"};
     }
     schemas_[idx] = sc;
diff --git a/hybridse/src/codegen/insert_row_builder.cc b/hybridse/src/codegen/insert_row_builder.cc
@@ -58,7 +58,7 @@ absl::StatusOr<std::shared_ptr<int8_t>> InsertRowBuilder::ComputeRow(absl::Span<
 }
 
 absl::StatusOr<int8_t*> InsertRowBuilder::ComputeRowUnsafe(absl::Span<node::ExprNode* const> values) {
-    if (schema_->size() != values.size()) {
+    if (static_cast<size_t>(schema_->size()) != values.size()) {
         return absl::FailedPreconditionError(
             absl::Substitute("invalid expression number, expect $0, but got $1", schema_->size(), values.size()));
     }
diff --git a/hybridse/src/codegen/struct_ir_builder.cc b/hybridse/src/codegen/struct_ir_builder.cc
@@ -301,7 +301,7 @@ absl::StatusOr<NativeValue> Combine(CodeGenContextBase* ctx, const NativeValue d
     llvm::Value* input_arrays = builder->CreateAlloca(input_arr_type, builder->getInt32(args.size()), "array_data");
     node::NodeManager nm;
     std::vector<NativeValue> casted_args(args.size());
-    for (int i = 0; i < args.size(); ++i) {
+    for (size_t i = 0; i < args.size(); ++i) {
         const node::TypeNode* tp = nullptr;
         if (!GetFullType(&nm, args.at(i).GetType(), &tp)) {
             return absl::InternalError("codegen error: fail to get valid type from llvm value");
diff --git a/hybridse/src/node/plan_node.cc b/hybridse/src/node/plan_node.cc
@@ -231,6 +231,10 @@ std::string NameOfPlanNodeType(const PlanType &type) {
             return "kPlanTypeAlterUser";
         case kPlanTypeCallStmt:
             return "kPlanTypeCallStmt";
+        case kPlanTypeGrant:
+            return "kPlanTypeGrant";
+        case kPlanTypeRevoke:
+            return "kPlanTypeRevoke";
         case kUnknowPlan:
             return std::string("kUnknow");
     }
diff --git a/hybridse/src/passes/expression/cache_expressions.cc b/hybridse/src/passes/expression/cache_expressions.cc
@@ -37,7 +37,7 @@ std::string CallExprKey(const node::CallExprNode* call) {
 
 base::Status CacheExpressions::Apply(node::ExprAnalysisContext* ctx, node::ExprNode* expr, node::ExprNode** out) {
     *out = expr;
-    for (int i = 0; i < expr->GetChildNum(); ++i) {
+    for (size_t i = 0; i < expr->GetChildNum(); ++i) {
         node::ExprNode* co = nullptr;
         CHECK_STATUS(Apply(ctx, expr->GetChild(i), &co));
         if (co != nullptr && co != expr->GetChild(i)) {
diff --git a/hybridse/src/rewriter/ast_rewriter.cc b/hybridse/src/rewriter/ast_rewriter.cc
@@ -459,7 +459,7 @@ class RequestQueryRewriteUnparser : public zetasql::parser::Unparser {
 
     void constSelectListAsConfigClause(const std::vector<const zetasql::ASTExpression*>& selects, void* data) {
         print("CONFIG (execute_mode = 'request', values = (");
-        for (int i = 0; i < selects.size(); ++i) {
+        for (size_t i = 0; i < selects.size(); ++i) {
             selects.at(i)->Accept(this, data);
             if (i + 1 < selects.size()) {
                 print(",");
diff --git a/hybridse/src/udf/default_defs/array_def.cc b/hybridse/src/udf/default_defs/array_def.cc
@@ -104,7 +104,7 @@ void SplitString(StringRef* str, StringRef* delimeter, ArrayRef<StringRef>* arra
 
 void array_join(ArrayRef<StringRef>* arr, StringRef* del, bool del_null, StringRef* out) {
     int sz = 0;
-    for (int i = 0; i < arr->size; ++i) {
+    for (size_t i = 0; i < arr->size; ++i) {
         if (!arr->nullables[i]) {
             if (!del_null && i > 0) {
                 sz += del->size_;
@@ -117,7 +117,7 @@ void array_join(ArrayRef<StringRef>* arr, StringRef* del, bool del_null, StringR
     memset(buf, 0, sz);
 
     int32_t idx = 0;
-    for (int i = 0; i < arr->size; ++i) {
+    for (size_t i = 0; i < arr->size; ++i) {
         if (!arr->nullables[i]) {
             if (!del_null && i > 0) {
                 memcpy(buf + idx, del->data_, del->size_);
diff --git a/hybridse/src/udf/default_defs/window_functions_def.cc b/hybridse/src/udf/default_defs/window_functions_def.cc
@@ -169,7 +169,7 @@ struct NthValueWhere {
                 if (ctr->nth > 0) {
                     // nth from window start
                     ctr->data.emplace(container::ContainerStorageTypeTrait<T>::to_stored_value(value), value_is_null);
-                    if (ctr->data.size() > ctr->nth) {
+                    if (ctr->data.size() > static_cast<size_t>(ctr->nth)) {
                         ctr->data.pop();
                     }
                 } else {
@@ -189,7 +189,7 @@ struct NthValueWhere {
             absl::Cleanup clean = [ctr]() { ctr->~ContainerT(); };
 
             // count from window end
-            if (ctr->nth == 0 || ctr->data.empty() || (ctr->nth > 0 && ctr->data.size() < ctr->nth)) {
+            if (ctr->nth == 0 || ctr->data.empty() || (ctr->nth > 0 && ctr->data.size() < static_cast<size_t>(ctr->nth))) {
                 // 1. invalid input: nth = 0
                 // 2. queue empty when nth < 0
                 // 3. queue size not equal to nth (when nth > 0)
diff --git a/hybridse/src/udf/udf.cc b/hybridse/src/udf/udf.cc
@@ -1466,10 +1466,10 @@ void array_combine(codec::StringRef *del, int32_t cnt, ArrayRef<codec::StringRef
     auto real_sz = products.size();
     v1::AllocManagedArray(out, products.size());
 
-    for (int prod_idx = 0; prod_idx < products.size(); ++prod_idx) {
+    for (size_t prod_idx = 0; prod_idx < products.size(); ++prod_idx) {
         auto &prod = products.at(prod_idx);
         int32_t sz = 0;
-        for (int i = 0; i < prod.size(); ++i) {
+        for (size_t i = 0; i < prod.size(); ++i) {
             if (!data[i]->nullables[prod.at(i)]) {
                 // delimiter would be empty string if null
                 if (i > 0) {
@@ -1485,7 +1485,7 @@ void array_combine(codec::StringRef *del, int32_t cnt, ArrayRef<codec::StringRef
         }
         auto buf = v1::AllocManagedStringBuf(sz);
         int32_t idx = 0;
-        for (int i = 0; i < prod.size(); ++i) {
+        for (size_t i = 0; i < prod.size(); ++i) {
             if (!data[i]->nullables[prod.at(i)]) {
                 if (i > 0 && del->size_ > 0) {
                     memcpy(buf + idx, del->data_, del->size_);
diff --git a/hybridse/src/vm/engine.cc b/hybridse/src/vm/engine.cc
@@ -455,7 +455,7 @@ int32_t RequestRunSession::Run(const Row& in_row, Row* out_row) {
     return Run(std::dynamic_pointer_cast<SqlCompileInfo>(compile_info_)->get_sql_context().cluster_job->main_task_id(),
                in_row, out_row);
 }
-int32_t RequestRunSession::Run(const uint32_t task_id, const Row& in_row, Row* out_row) {
+int32_t RequestRunSession::Run(int32_t task_id, const Row& in_row, Row* out_row) {
     ::hybridse::codec::Row row = in_row;
     std::vector<::hybridse::codec::Row>& sql_request_rows =
         std::dynamic_pointer_cast<SqlCompileInfo>(GetCompileInfo())->get_sql_context().request_rows;
@@ -499,7 +499,7 @@ int32_t BatchRequestRunSession::Run(const std::vector<Row>& request_batch, std::
     return Run(std::dynamic_pointer_cast<SqlCompileInfo>(compile_info_)->get_sql_context().cluster_job->main_task_id(),
                request_batch, output);
 }
-int32_t BatchRequestRunSession::Run(const uint32_t id, const std::vector<Row>& request_batch,
+int32_t BatchRequestRunSession::Run(int32_t id, const std::vector<Row>& request_batch,
                                     std::vector<Row>& output) {
     auto info = std::dynamic_pointer_cast<SqlCompileInfo>(GetCompileInfo());
     std::vector<::hybridse::codec::Row>& sql_request_rows = info->get_sql_context().request_rows;
diff --git a/hybridse/src/vm/physical_op.cc b/hybridse/src/vm/physical_op.cc
@@ -1721,7 +1721,7 @@ absl::StatusOr<ColProducerTraceInfo> PhysicalSetOperationNode::TraceColID(absl::
     ColProducerTraceInfo vec;
 
     // every producer node in set operation is able to backtrace columns in current node context
-    for (int i = 0; i < GetProducerCnt(); ++i) {
+    for (size_t i = 0; i < GetProducerCnt(); ++i) {
         size_t child_col_id = 0;
         auto s = GetProducer(i)->schemas_ctx()->ResolveColumnID("", "", std::string(col_name), &child_col_id);
         if (!s.isOK()) {
diff --git a/hybridse/src/vm/runner.cc b/hybridse/src/vm/runner.cc
@@ -1805,7 +1805,7 @@ std::shared_ptr<TableHandler> RequestAggUnionRunner::RequestUnionWindow(
     }
 
     // 2. iterate over agg table from end_base until start_base (both inclusive)
-    int64_t prev_ts_start = INT64_MAX;
+    uint64_t prev_ts_start = UINT64_MAX;
     while (start_base.has_value() && start_base <= end_base && agg_it != nullptr && agg_it->Valid()) {
         if (max_size > 0 && cnt >= max_size) {
             break;
@@ -1829,7 +1829,7 @@ std::shared_ptr<TableHandler> RequestAggUnionRunner::RequestUnionWindow(
             // FIXME(zhanghao): check cnt and rows_start_preceding meanings
             int next_incr = num_rows > 0 ? num_rows - 1 : 0;
             auto range_status = window_range.GetWindowPositionStatus(cnt + next_incr > rows_start_preceding,
-                                                                     ts_start > end, ts_start < start);
+			static_cast<int64_t>(ts_start) > end, static_cast<int64_t>(ts_start) < start);
             if ((max_size > 0 && cnt + next_incr >= max_size) || WindowRange::kExceedWindow == range_status) {
                 start_base = ts_end + 1;
                 break;
@@ -1890,7 +1890,7 @@ std::shared_ptr<TableHandler> RequestAggUnionRunner::RequestUnionWindow(
 
             int next_incr = total_rows > 0 ? total_rows - 1 : 0;
             auto range_status = window_range.GetWindowPositionStatus(cnt + next_incr > rows_start_preceding,
-                                                                     ts_start > end, ts_start < start);
+	            static_cast<int64_t>(ts_start) > end, static_cast<int64_t>(ts_start) < start);
             if ((max_size > 0 && cnt + next_incr >= max_size) || WindowRange::kExceedWindow == range_status) {
                 start_base = ts_end_range + 1;
                 break;
diff --git a/src/auth/user_access_manager.cc b/src/auth/user_access_manager.cc
@@ -61,7 +61,7 @@ void UserAccessManager::SyncWithDB() {
             row_view.GetStrValue(1, &user);
             row_view.GetStrValue(2, &password);
             row_view.GetStrValue(5, &privilege_level_str);
-            openmldb::nameserver::PrivilegeLevel privilege_level;
+            openmldb::nameserver::PrivilegeLevel privilege_level = openmldb::nameserver::PrivilegeLevel::NO_PRIVILEGE;
             ::openmldb::nameserver::PrivilegeLevel_Parse(privilege_level_str, &privilege_level);
             UserRecord user_record = {password, privilege_level};
             if (host == "%") {
diff --git a/src/base/linenoise.cc b/src/base/linenoise.cc
@@ -545,7 +545,9 @@ static void refreshSingleLine(struct linenoiseState *l) {
     /* Move cursor to original position. */
     snprintf(seq, sizeof(seq), "\r\x1b[%dC", static_cast<int>(pos + plen));
     abAppend(&ab, seq, strlen(seq));
-    write(fd, ab.b, ab.len);
+    if (write(fd, ab.b, ab.len) == -1) {
+        perror("terminal write failed");
+    }
     /* Can't recover from write error. */
     abFree(&ab);
 }
@@ -630,7 +632,9 @@ static void refreshMultiLine(struct linenoiseState *l) {
     lndebug("\n");
     l->oldpos = l->pos;
 
-    write(fd, ab.b, ab.len); /* Can't recover from write error. */
+    if (write(fd, ab.b, ab.len) == -1) { /* Can't recover from write error. */
+        perror("terminal write failed");
+    }
     abFree(&ab);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ absl::StatusOr<std::shared_ptr<int8_t>> InsertRowBuilder::ComputeRow(absl::Span<`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`absl::StatusOr<int8_t> InsertRowBuilder::ComputeRowUnsafe(absl::Span<node::ExprNode const> values) {`
`61`		`- if (schema_->size() != values.size()) {`
	`61`	`+ if (static_cast<size_t>(schema_->size()) != values.size()) {`
`62`	`62`	`return absl::FailedPreconditionError(`
`63`	`63`	`absl::Substitute("invalid expression number, expect $0, but got $1", schema_->size(), values.size()));`
`64`	`64`	`}`