Skip to content

Commit 58dc383

Browse files
committed
move back tests in disk_table_test
1 parent 7c0e0ec commit 58dc383

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/storage/disk_table_test.cc

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,8 @@ TEST_F(DiskTableTest, MultiDimensionPut) {
120120
::openmldb::common::StorageMode::kHDD, table_path);
121121
ASSERT_TRUE(table->Init());
122122
ASSERT_EQ(3, (int64_t)table->GetIdxCnt());
123-
// some functions in disk table need to be implemented.
124-
// refer to issue #1238
125-
// ASSERT_EQ(0, table->GetRecordIdxCnt());
126-
// ASSERT_EQ(0, table->GetRecordCnt());
123+
ASSERT_EQ(0, table->GetRecordIdxCnt());
124+
ASSERT_EQ(0, table->GetRecordCnt());
127125

128126
auto meta = ::openmldb::test::GetTableMeta({"idx0", "idx1", "idx2"});
129127
::openmldb::codec::SDKCodec sdk_codec(meta);
@@ -143,9 +141,7 @@ TEST_F(DiskTableTest, MultiDimensionPut) {
143141
ASSERT_EQ(0, sdk_codec.EncodeRow(row, &value));
144142
bool ok = table->Put(1, value, dimensions);
145143
ASSERT_TRUE(ok);
146-
// some functions in disk table need to be implemented.
147-
// refer to issue #1238
148-
// ASSERT_EQ(3, table->GetRecordIdxCnt());
144+
ASSERT_EQ(3, table->GetRecordIdxCnt());
149145

150146
Ticket ticket;
151147
TableIterator* it = table->NewIterator(0, "yjdim0", ticket);

0 commit comments

Comments
 (0)