fix: detect self reference circual dependency

Author: 4strodev

pkg/container/container.go

@@ -131,6 +131,13 @@ func (c *Container) setConnections() error {
 		resType := reflect.TypeOf(node.Val.Resolver)
 		for i := 0; i < resType.NumIn(); i++ {
 			dependencyType := resType.In(i)
+
+			if node.Val.Type() == dependencyType {
+				return fmt.Errorf("circular depndency found: %v", []*graph.Node[resolver.DependencyResolver[any]]{
+					node,
+				})
+			}
+
 			dependencyNode, err := c.getNodeFor(dependencyType)
 			if err != nil {
 				return err

pkg/container/container_test.go

@@ -43,6 +43,17 @@ func TestDetectCircularDependencies(t *testing.T) {
 	require.NoError(t, err, "circular dependencies should not be detected")
 }
 
+func TestDetectCircularDependencies_SelfReference(t *testing.T) {
+	cont := container.New()
+
+	cont.AddDependency(func(s MyService) MyService {
+		return MyService{}
+	})
+
+	_, err := cont.DetectCircularDependencies()
+	require.Error(t, err, "should detect self reference")
+}
+
 func TestResolve(t *testing.T) {
 	cont := container.New()
 
@@ -99,3 +110,20 @@ func TestResolveToken(t *testing.T) {
 	require.NoError(t, err)
 	require.NotNil(t, buf)
 }
+
+func TestResolveToken_WithDependencies(t *testing.T) {
+	cont := container.New()
+
+	dependantResolver := func(service MyService) *bytes.Buffer {
+		return bytes.NewBuffer([]byte{})
+	}
+
+	err := cont.AddTokenDependency("buffer", dependantResolver)
+	require.NoError(t, err)
+
+	cont.AddDependency(NewService)
+
+	buf, err := container.ResolveToken[*bytes.Buffer](cont, "buffer")
+	require.NoError(t, err)
+	require.NotNil(t, buf)
+}