Skip to content

Commit 114fd07

Browse files
committed
Fix instance variable definition and typing
1 parent 5addcd2 commit 114fd07

File tree

1 file changed

+7
-4
lines changed
  • django_features/custom_fields/models

1 file changed

+7
-4
lines changed

django_features/custom_fields/models/base.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,6 @@ class Meta:
124124

125125
class CustomFieldBaseModel(TimeStampedModel):
126126
_custom_field_type_attr: str | None = None
127-
_custom_values_to_save: list[CustomValue] = []
128-
_custom_values_to_remove: list[CustomValue] = []
129127

130128
custom_values = models.ManyToManyField(
131129
blank=True,
@@ -137,15 +135,20 @@ class CustomFieldBaseModel(TimeStampedModel):
137135
class Meta:
138136
abstract = True
139137

138+
def __init__(self, *args: Any, **kwargs: Any) -> None:
139+
super().__init__(*args, **kwargs)
140+
self._custom_values_to_save: list[CustomValue] = []
141+
self._custom_values_to_remove: list[CustomValue] = []
142+
140143
def save(self, **kwargs: Any) -> None:
141-
super().save(**kwargs)
144+
super().save(**kwargs) # type: ignore
142145
if self._custom_values_to_remove:
143146
self.custom_values.remove(*self._custom_values_to_remove)
144147

145148
_custom_values_to_add: set[CustomValue] = set()
146149
existing_custom_values = self.custom_values.all()
147150
for value in self._custom_values_to_save:
148-
value.save()
151+
value.save() # type: ignore
149152
if value not in existing_custom_values:
150153
_custom_values_to_add.add(value)
151154
if _custom_values_to_add:

0 commit comments

Comments
 (0)