Skip to content

Commit a403cc1

Browse files
authored
Merge pull request #12 from 4teamwork/jch/TI-2994
Fix AttributeError when overriding serializer
2 parents 93edeed + 7363a8a commit a403cc1

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

changes/TI-2994.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixes AttributeError when overriding the init function of the CustomFieldBaseModelSerializer because of the params. (`TI-2994 <https://4teamwork.atlassian.net/browse/TI-2994>`_)

django_features/custom_fields/serializers.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ def get_choices(self, obj: CustomField) -> list:
6363

6464

6565
class CustomFieldBaseModelSerializer(serializers.ModelSerializer):
66+
_exclude_custom_fields = False
6667
_custom_fields: list[CustomFieldData] = []
6768
_unique_choice_field = "id"
6869
_write_only_serializer = False
@@ -76,13 +77,13 @@ def __init__(
7677
self,
7778
instance: Any = None,
7879
data: Any = empty,
79-
exclude_custom_fields: bool = False,
80-
write_only_serializer: bool = False,
8180
**kwargs: Any,
8281
) -> None:
83-
self.exclude_custom_fields: bool = exclude_custom_fields
84-
self.write_only_serializer = (
85-
write_only_serializer or self._write_only_serializer
82+
self.exclude_custom_fields: bool = kwargs.get(
83+
"exclude_custom_fields", self._exclude_custom_fields
84+
)
85+
self.write_only_serializer = kwargs.get(
86+
"write_only_serializer", self._write_only_serializer
8687
)
8788
super().__init__(instance, data, **kwargs)
8889

0 commit comments

Comments
 (0)