Merge pull request #8208 from 4teamwork/es/TI-3331-fix-pdf-dossier-tasks-view

Fix generating task listing pdf for tasks having special chars in the response comments

Author: elioschmutz

changes/TI-3331.bugfix

@@ -0,0 +1 @@
+Fix generating task listing pdf for tasks having special chars in the response comments. [elioschmutz]

opengever/latex/listing.py

@@ -17,10 +17,11 @@
 from zope.component import adapter
 from zope.interface import implementer
 from zope.interface import Interface
-import re
 
 
-STRIP_HTML_RE = re.compile('<[^<]+?>')
+def transform_html_to_text(value):
+    transformer = api.portal.get_tool('portal_transforms')
+    return transformer.convert('html_to_text', value or '').getData()
 
 
 class Column(object):
@@ -331,7 +332,7 @@ def get_columns(self):
             Column('text',
                    _('label_description', default='Description'),
                    '50%',
-                   lambda item: STRIP_HTML_RE.sub('', item.text if item.text else "")),
+                   lambda item: transform_html_to_text(item.text if item.text else "")),
         ]
 
 

opengever/latex/tests/test_dossiertasks.py

@@ -125,6 +125,39 @@ def test_dossier_tasks_history(self, browser):
             layout = DefaultLayout(dossier, dossier.REQUEST, PDFBuilder())
             dossiertasks = getMultiAdapter((dossier, dossier.REQUEST, layout),
                                            ILaTeXView)
+
             tasks_data = dossiertasks.get_render_arguments()['task_data_list']
             self.assertEqual(1, len(tasks_data))
             self.assertIn("response text", tasks_data[0]['history'])
+
+    @browsing
+    def test_dossier_tasks_history_with_html_response(self, browser):
+        repository = create(Builder('repository_root')
+                            .titled(u'Repository'))
+        dossier = create(Builder('dossier')
+                         .titled(u'Anfr\xf6gen 2015')
+                         .within(repository)
+                         .having(responsible=self.user.userid))
+
+        browser.login().visit(dossier)
+        factoriesmenu.add('Task')
+        browser.fill({'Title': 'Task title',
+                      'Task type': 'To comment'})
+
+        form = browser.find_form_by_field('Responsible')
+        form.find_widget('Responsible').fill(TEST_USER_ID)
+        browser.find('Save').click()
+
+        browser.open('http://nohost/plone/repository/dossier-1/task-1')
+        browser.click_on("Resolve")
+        browser.fill({'Response': u'<p>Eine &amp; Aufgabe</p>'})
+        browser.click_on("Save")
+
+        with provide_dossier_task_layer(dossier.REQUEST):
+            layout = DefaultLayout(dossier, dossier.REQUEST, PDFBuilder())
+            dossiertasks = getMultiAdapter((dossier, dossier.REQUEST, layout),
+                                           ILaTeXView)
+
+            tasks_data = dossiertasks.get_render_arguments()['task_data_list']
+            self.assertEqual(1, len(tasks_data))
+            self.assertIn("Eine \\& Aufgabe", tasks_data[0]['history'])