Skip to content

Commit c4a5b0f

Browse files
author
Niklaus Johner
committed
Adapt tests for skipping invalid rows.
1 parent 075137c commit c4a5b0f

File tree

1 file changed

+13
-47
lines changed

1 file changed

+13
-47
lines changed

opengever/bundle/tests/test_os_migration.py

Lines changed: 13 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def test_repository_excel_analyser_os_test_branch_and_leaf_creation(self):
125125
analyser = RepositoryExcelAnalyser(migration_file, analysis_file)
126126
analyser.analyse()
127127

128-
self.assertEqual(6, len(analyser.analysed_rows))
128+
self.assertEqual(5, len(analyser.analysed_rows))
129129

130130
self.assertDictEqual(
131131
{'is_valid': True,
@@ -161,24 +161,7 @@ def test_repository_excel_analyser_os_test_branch_and_leaf_creation(self):
161161
'uid': self.empty_repofolder.UID()},
162162
analyser.analysed_rows[1])
163163

164-
self.assertDictEqual(
165-
{'is_valid': True,
166-
'leaf_node_violated': False,
167-
'new_item': OperationItem(),
168-
'new_number': None,
169-
'new_parent_position': None,
170-
'new_parent_uid': None,
171-
'new_position_parent_guid': None,
172-
'new_position_parent_position': None,
173-
'new_position_guid': None,
174-
'new_title': None,
175-
'old_item': OperationItem(3, u"Spinn\xe4nnetzregistrar", ''),
176-
'permissions': None,
177-
'repository_depth_violated': False,
178-
'uid': self.inactive_repofolder.UID()},
179-
analyser.analysed_rows[2])
180-
181-
new_branch_guid = analyser.analysed_rows[3]['new_position_guid']
164+
new_branch_guid = analyser.analysed_rows[2]['new_position_guid']
182165
reporoot_guid = IAnnotations(self.repository_root).get(BUNDLE_GUID_KEY)
183166
self.assertIsNotNone(new_branch_guid)
184167
self.assertDictEqual(
@@ -202,9 +185,9 @@ def test_repository_excel_analyser_os_test_branch_and_leaf_creation(self):
202185
'read': []},
203186
'repository_depth_violated': False,
204187
'uid': None},
205-
analyser.analysed_rows[3])
188+
analyser.analysed_rows[2])
206189

207-
guid = analyser.analysed_rows[4]['new_position_guid']
190+
guid = analyser.analysed_rows[3]['new_position_guid']
208191
self.assertIsNotNone(guid)
209192
self.assertDictEqual(
210193
{'is_valid': True,
@@ -227,9 +210,9 @@ def test_repository_excel_analyser_os_test_branch_and_leaf_creation(self):
227210
'read': []},
228211
'repository_depth_violated': False,
229212
'uid': None},
230-
analyser.analysed_rows[4])
213+
analyser.analysed_rows[3])
231214

232-
uid = analyser.analysed_rows[5]['new_parent_uid']
215+
uid = analyser.analysed_rows[4]['new_parent_uid']
233216
self.assertIsNotNone(uid)
234217

235218
self.assertDictEqual(
@@ -247,7 +230,7 @@ def test_repository_excel_analyser_os_test_branch_and_leaf_creation(self):
247230
'permissions': None,
248231
'repository_depth_violated': False,
249232
'uid': self.leaf_repofolder.UID()},
250-
analyser.analysed_rows[5])
233+
analyser.analysed_rows[4])
251234

252235
def test_repository_excel_analyser_os_test_migration(self):
253236
self.login(self.manager)
@@ -256,7 +239,7 @@ def test_repository_excel_analyser_os_test_migration(self):
256239
analyser = RepositoryExcelAnalyser(migration_file, analysis_file)
257240
analyser.analyse()
258241

259-
self.assertEqual(6, len(analyser.analysed_rows))
242+
self.assertEqual(5, len(analyser.analysed_rows))
260243

261244
self.assertDictEqual(
262245
{'is_valid': True,
@@ -292,24 +275,7 @@ def test_repository_excel_analyser_os_test_migration(self):
292275
'uid': self.empty_repofolder.UID()},
293276
analyser.analysed_rows[1])
294277

295-
self.assertDictEqual(
296-
{'is_valid': True,
297-
'leaf_node_violated': False,
298-
'new_item': OperationItem(),
299-
'new_number': None,
300-
'new_parent_position': None,
301-
'new_parent_uid': None,
302-
'new_position_parent_guid': None,
303-
'new_position_parent_position': None,
304-
'new_position_guid': None,
305-
'new_title': None,
306-
'old_item': OperationItem(3, u"Spinn\xe4nnetzregistrar", ''),
307-
'permissions': None,
308-
'repository_depth_violated': False,
309-
'uid': self.inactive_repofolder.UID()},
310-
analyser.analysed_rows[2])
311-
312-
guid = analyser.analysed_rows[3]['new_position_guid']
278+
guid = analyser.analysed_rows[2]['new_position_guid']
313279
self.assertIsNotNone(guid)
314280
self.assertDictEqual(
315281
{'is_valid': True,
@@ -332,9 +298,9 @@ def test_repository_excel_analyser_os_test_migration(self):
332298
'read': []},
333299
'repository_depth_violated': False,
334300
'uid': None},
335-
analyser.analysed_rows[3])
301+
analyser.analysed_rows[2])
336302

337-
guid = analyser.analysed_rows[4]['new_position_guid']
303+
guid = analyser.analysed_rows[3]['new_position_guid']
338304
self.assertIsNotNone(guid)
339305
self.assertDictEqual(
340306
{'is_valid': True,
@@ -357,7 +323,7 @@ def test_repository_excel_analyser_os_test_migration(self):
357323
'read': []},
358324
'repository_depth_violated': False,
359325
'uid': None},
360-
analyser.analysed_rows[4])
326+
analyser.analysed_rows[3])
361327

362328
self.assertDictEqual(
363329
{'is_valid': True,
@@ -374,7 +340,7 @@ def test_repository_excel_analyser_os_test_migration(self):
374340
'permissions': None,
375341
'repository_depth_violated': False,
376342
'uid': self.leaf_repofolder.UID()},
377-
analyser.analysed_rows[5])
343+
analyser.analysed_rows[4])
378344

379345
def test_repository_excel_analyser_os_test_invalid(self):
380346
log_list = []

0 commit comments

Comments
 (0)