Tests fails on both mac and linux for 4.5.*

[kgs]

Hi,

when I checkout current master (https://github.com/51Degrees/device-detection-cxx/tree/5c6f224edbef8527e8051f68e8050c1f849687d4) and try to run tests, two of them fail.

Here is what I do:

git clone --recurse-submodules https://github.com/51Degrees/device-detection-cxx.git
cd device-detection-cxx
mkdir build
cd build
cmake ..
cmake --build .
make test

Here is what I get:

...
99% tests passed, 2 tests failed out of 936

Total Test time (real) = 372.45 sec

The following tests FAILED:
        882 - ResultsHashSerializerTests.basicJSONSerialization (Failed)
        883 - ResultsHashSerializerTests.unhappyCases (Failed)

This happens both on mac with CLang where CMake 4.1.2 output is this:

-- The CXX compiler identification is AppleClang 17.0.0.17000603
-- The C compiler identification is AppleClang 17.0.0.17000603
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Setting default CMAKE_BUILD_TYPE  to Release
-- TESTCOVERAGE_ENABLED=FALSE
-- FIFTYONE_COMMON_CXX_BUILD_TESTING=OFF
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- Configuring done (0.1s)
-- Generating done (0.0s)

... and Linux Rocky 9, where CMake 3.26.5 output is this:

-- The CXX compiler identification is GNU 11.5.0
-- The C compiler identification is GNU 11.5.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Setting default CMAKE_BUILD_TYPE  to Release
-- TESTCOVERAGE_ENABLED=FALSE
-- Found GCC's libatomic.so: lib=/usr/lib64/libatomic.so.1
-- FIFTYONE_COMMON_CXX_BUILD_TESTING=OFF
-- Configuring done (0.0s)
-- Generating done (0.0s)

PS. Same happens when I checkout 4.5.0.
PS2. When building with additional flags set I have same issue as: #316

[justadreamer]

Hi @kgs!
Thanks for noticing this!

These tests definitely pass on our CI (otherwise we'd see failures under the Actions tab), but perhaps because they are using a full enterprise data file instead of lite data file. We'll make a note of improving the tests and make use of the Lite data file. In the meantime do you have a paid subscription of 51Degrees and are you able to test with the full enterprise data file?
Thanks

cc: @Tracy51D

[kgs]

Hi @justadreamer!

Thanks for answer, yep, that totally makes sense that data file differences are source of this. We are paying subscribers, but testing with enterprise data is not feasible long term (which version? updating every time is cumbersome...). Is there a chance that fix will happen in near future?

Maybe it is also good idea to add CI runs with lite data file since this is developer experience after cloning repo?

[justadreamer]

Hi @kgs

I believe this has been addressed and the tests should now pass both with Lite and Full data file.

Please let us know if this still does not work on your end and thanks for reporting!