Skip to content

prebid-server: 511 512 values overflow device.geo.ipservice #5

@justadreamer

Description

@justadreamer

Check this out:
https://github.com/prebid/openrtb/blob/main/adcom1/ip_location_service.go

PBS-Go won't allow setting 511 or 512 for device.geo.ipservice because int8 is -127..127, and 511 or 512 will overflow it.

PBS-Java does not have this problem as it uses Integer type for that field.

The fix is changing the type of the field obviously and adapting the corresponding code on the call site - we might just contribute a PR without an issue, it's accepted easier usually.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions