refactor: small updates to eslint config (#618)

* refactor: cleanup eslint config

- Use the base eslint config without the tseslint.configure
  helper function.

* refactor: properly type jest config files

* refactor: address linter error and warnings

Author: ecshreve

eslint.config.js

@@ -5,46 +5,49 @@ import jestPlugin from 'eslint-plugin-jest';
 import globals from 'globals';
 import tseslint from 'typescript-eslint';
 
-export default tseslint.config(
+export default [
   {
+    name: 'base ignore',
     ignores: ['**/coverage/**', '**/dist/**', '**/node_modules/**'],
   },
+  eslint.configs.recommended,
   {
-    extends: [
-      eslint.configs.recommended,
-      ...tseslint.configs.recommended,
-    ],
+    name: 'javascript',
+    files: ['**/*.js'],
+    languageOptions: {
+      globals: {
+        ...globals.jquery,
+        ...globals.browser,
+      },
+    },
+  },
+  ...tseslint.configs.recommended,
+  {
+    name: 'typescript',
+    files: ['**/*.ts'],
     languageOptions: {
       parser: tseslint.parser,
       parserOptions: {
         projectService: true,
         tsconfigRootDir: import.meta.dirname,
       },
       globals: {
-        ...globals.jquery,
-        ...globals.browser,
         ...globals.node,
         ...globals.jest,
       },
     },
     rules: {
-      '@typescript-eslint/no-unused-vars': 'off',
-      '@typescript-eslint/no-unused-expressions': 'off',
+      '@typescript-eslint/no-unused-vars': 'warn',
+      '@typescript-eslint/no-unused-expressions': 'warn',
       '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-var-requires': 'warn',
     },
   },
   {
-    // disable type-aware linting on JS files
-    files: ['**/*.js'],
-    ...tseslint.configs.disableTypeChecked
-  },
-  {
-    // enable jest rules on test files
+    name: 'jest',
     files: ['**/*.test.{js,ts}'],
     ...jestPlugin.configs['flat/recommended'],
     rules: {
       '@typescript-eslint/no-unsafe-argument': 'off',
     },
   },
-);
+];

jest.config.integration.ts

@@ -1,6 +1,12 @@
-import config from './jest.config';
+import { Config } from '@jest/types';
+import baseConfig from './jest.config';
+
+const integrationConfig: Config.InitialOptions = {
+  ...baseConfig,
+  displayName: 'Integration Tests',
+  testRegex: '\\.itest\\.(js|ts)$',
+  silent: true,
+};
 
-config.testRegex = '\\.itest\\.(js|ts)$'; //Overriding testRegex option
 console.log('RUNNING INTEGRATION TESTS');
-config.silent = true; //Overriding silent option
-export default config;
+export default integrationConfig;

jest.config.ts

@@ -1,5 +1,6 @@
-/** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
-export default {
+import { Config } from '@jest/types';
+
+const baseConfig: Config.InitialOptions = {
   preset: 'ts-jest',
   testEnvironment: 'jest-environment-node',
   collectCoverage: true,
@@ -19,3 +20,5 @@ export default {
   },
   transform: {},
 };
+
+export default baseConfig;

jest.config.unit.ts

@@ -1,7 +1,13 @@
-import config from './jest.config';
-config.testRegex = '\\.test\\.(js|ts)$'; //Overriding testRegex option
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
-(config.setupFilesAfterEnv = ['./src/tests/support/setupRedisMock.ts']),
-  console.log('RUNNING UNIT TESTS');
-export default config;
+import { Config } from '@jest/types';
+import baseConfig from './jest.config';
+
+const unitConfig: Config.InitialOptions = {
+  ...baseConfig,
+  displayName: 'Unit Tests',
+  testRegex: '\\.test\\.(js|ts)$',
+  setupFilesAfterEnv: ['./src/tests/support/setupRedisMock.ts'],
+  silent: false,
+};
+
+console.log('RUNNING UNIT TESTS');
+export default unitConfig;