Feedback

[Cyril-debug]

Hello,
I tried different IL files with master branch of echidna on Windows native compilation (MSVC).
I have the following remarks:

• In README.md, dependency to jansson is not mentioned.
• The goal of this analysis is to port this solution on small hardware. By replacing libev calls by something very simple (like a single timer notification).
• ll.c file contains calls to pthread_rwlock_xxx() API. Can it be possible to offer an API abstraction (to mutexes or pthread_rwlock_xxx)?
• On /runtime, /protobuf and, /operator folders, there is files that are named identically from parent folder (like parameter.c, function.c, ...). On MSVC, I had issue as filenames are identical. I renamed it with a prefix (/runtime/rt_parameter.c for example)
• Is it possible to have a compilation directive to remove json layer
• In /src/symbol.c, _symbol_calculate_size() there is a compilation issue with an uninitialized pointer (pSymbol).
• In /src/value.c, _value_destroy(); pDestroy = va_arg(sArg, void (*)(void *)); doesn't compile. A change to pDestroy = va_arg(sArg, void *); is necessary for MSVC.
• Maybe it is due to Windows port but:

1. rpiface.il is always writing 0
2. sine.il is always writing 0
3. blink is working fine

• I did a change in "/examples/ctu.il" by replacing "dbg count.q" to "dbg count". When running the code, a crash appears in /src/value.c in value_copy(). Src->Meta is not valid. For sure it is due to an invalid modification in .il file.

Let me know if you need more information.
Best regards,
Cyril

[61131]

Cyril,

Firstly, thank you for your feedback and the time that you have spent looking at this project. I have not attempted any compilation on Windows and as such, this feedback is very useful. If you have made changes that you want incorporated, please raise a PR. I'll look to otherwise make some changes around the items raised next week (once I clear some items off my immediate to-do list).

Regards,
Rob

[Cyril-debug]

Rob,
As proposed, I created a PR that contains the changes mentioned before.
I created a "lock" API to switch easily between Linux, Windows and, later FreeRTOS.
I also fixed some warnings detected by static analysis (NULL pointer dereference and buffer overflow).

Best regards,
Cyril