refactor: use BuildManager (#19)

Author: 616b2f

.editorconfig

@@ -1,6 +1,19 @@
 # Remove the line below if you want to inherit .editorconfig settings from higher directories
 root = true
 
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = true
+
+[*.{json,xml}]
+indent_style = space
+indent_size = 2
+
+[nuget.config]
+indent_style = space
+indent_size = 2
+
 [*{Test,Tests}.cs]
 # Anonymous function can be made static
 dotnet_diagnostic.IDE0320.severity = none

src/bsp-server/BuildInitializeManager.cs

@@ -1,5 +1,6 @@
 using BaseProtocol;
 using bsp4csharp.Protocol;
+using Microsoft.Build.Execution;
 
 namespace dotnet_bsp;
 
@@ -34,6 +35,11 @@ public InitializeBuildResult GetInitializeResult()
         return initializeResult;
     }
 
+    public BuildManager GetBuildManager()
+    {
+        return BuildManager.DefaultBuildManager;
+    }
+
     public InitializeBuildParams GetInitializeParams()
     {
         EnsureInitialize();

src/bsp-server/Handlers/BuildTargetCleanCacheHandler.cs

@@ -1,7 +1,8 @@
 using BaseProtocol;
 using bsp4csharp.Protocol;
-using Microsoft.Build.Construction;
 using Microsoft.Build.Evaluation;
+using Microsoft.Build.Execution;
+using Microsoft.Build.Graph;
 using dotnet_bsp.Logging;
 
 namespace dotnet_bsp.Handlers;
@@ -21,44 +22,31 @@ public Task<CleanCacheResult> HandleRequestAsync(CleanCacheParams cleanCachePara
     {
         _initializeManager.EnsureInitialized();
 
+        var projects = new ProjectCollection();
         var cleanResult = false;
+        var targetFiles = BuildHelper.ExtractProjectsFromSolutions(cleanCacheParams.Targets);
+        var graph = new ProjectGraph(targetFiles, projects);
         var initParams = _initializeManager.GetInitializeParams();
         if (initParams.RootUri.IsFile)
         {
-            var projects = new ProjectCollection();
-            foreach (var target in cleanCacheParams.Targets)
-            {
-                var fileExtension = Path.GetExtension(target.ToString());
-                context.Logger.LogInformation("Target file extension {}", fileExtension);
-                if (fileExtension == ".sln")
-                {
-                    var slnFile = SolutionFile.Parse(target.ToString());
-
-                    var projectFilesInSln = slnFile.ProjectsInOrder
-                        .Where(x => 
-                            x.ProjectType == SolutionProjectType.KnownToBeMSBuildFormat ||
-                            x.ProjectType == SolutionProjectType.WebProject)
-                        .Select(x => x.AbsolutePath);
-
-                    foreach (var projectFile in projectFilesInSln)
-                    {
-                        projects.LoadProject(projectFile);
-                    }
-                }
-                else if (fileExtension == ".csproj")
-                {
-                    projects.LoadProject(target.ToString());
-                }
-            }
-
             var workspacePath = initParams.RootUri.LocalPath;
             context.Logger.LogInformation("GetLoadedProjects from {}", workspacePath);
-            foreach (var proj in projects.LoadedProjects)
-            {
-                var msBuildLogger = new MSBuildLogger(_baseProtocolClientManager, null, workspacePath);
-                context.Logger.LogInformation("Start clean for target: {}", proj.FullPath);
-                cleanResult |= proj.Build("Clean", new [] { msBuildLogger });
-            }
+            _baseProtocolClientManager.SendClearDiagnosticsMessage();
+
+            var buildManager = _initializeManager.GetBuildManager();
+            buildManager.BeginBuild(new BuildParameters
+                {
+                    Loggers = [
+                        new MSBuildLogger(_baseProtocolClientManager, null, workspacePath)
+                    ],
+                },
+                []);
+
+            context.Logger.LogInformation("Start clean for target: {}", targetFiles);
+            var graphCleanResult = buildManager.BuildRequest(new GraphBuildRequestData(graph, ["Clean"]));
+            context.Logger.LogInformation("Clean result: {}", graphCleanResult.OverallResult);
+            cleanResult = (graphCleanResult.OverallResult == BuildResultCode.Success);
+            buildManager.EndBuild();
         }
 
         var message = cleanResult ? "Cleaned" : "Not cleaned";

src/bsp-server/Handlers/BuildTargetCompileHandler.cs

@@ -1,8 +1,9 @@
 using BaseProtocol;
 using bsp4csharp.Protocol;
 using Microsoft.Build.Evaluation;
-using dotnet_bsp.Logging;
+using Microsoft.Build.Execution;
 using Microsoft.Build.Graph;
+using dotnet_bsp.Logging;
 
 namespace dotnet_bsp.Handlers;
 
@@ -23,7 +24,7 @@ public Task<CompileResult> HandleRequestAsync(CompileParams compileParams, Reque
 
         var projects = new ProjectCollection();
         var buildResult = true;
-        var targetFiles = compileParams.Targets.Select(x => x.ToString());
+        var targetFiles = BuildHelper.ExtractProjectsFromSolutions(compileParams.Targets);
         var graph = new ProjectGraph(targetFiles, projects);
         var initParams = _initializeManager.GetInitializeParams();
         if (initParams.RootUri.IsFile)
@@ -32,27 +33,24 @@ public Task<CompileResult> HandleRequestAsync(CompileParams compileParams, Reque
             context.Logger.LogInformation("GetLoadedProjects from {}", workspacePath);
             _baseProtocolClientManager.SendClearDiagnosticsMessage();
 
-            foreach (var proj in graph.ProjectNodesTopologicallySorted)
-            {
-                var globalProps = proj.ProjectInstance.GlobalProperties
-                    .Select(x => string.Format("{0}={1}", x.Key, x.Value))
-                    .ToArray();
-                context.Logger.LogInformation("Global Properties: {}", string.Join("\n", globalProps));
-                context.Logger.LogInformation("Start restore target: {}", proj.ProjectInstance.FullPath);
-                var msBuildLogger = new MSBuildLogger(_baseProtocolClientManager, compileParams.OriginId, workspacePath);
-                var result = proj.ProjectInstance.Build(["Restore"], [msBuildLogger]);
-                context.Logger.LogInformation($"{proj.ProjectInstance.FullPath} restore result: {result}");
-                buildResult &= result;
-            }
-
-            foreach (var proj in graph.ProjectNodesTopologicallySorted)
-            {
-                context.Logger.LogInformation("Start building target: {}", proj.ProjectInstance.FullPath);
-                var msBuildLogger = new MSBuildLogger(_baseProtocolClientManager, compileParams.OriginId, workspacePath);
-                var result = proj.ProjectInstance.Build(["Build"], [msBuildLogger]);
-                context.Logger.LogInformation($"{proj.ProjectInstance.FullPath} build result: {result}");
-                buildResult &= result;
-            }
+            var buildManager = _initializeManager.GetBuildManager();
+            buildManager.BeginBuild(new BuildParameters
+                {
+                    Loggers = [
+                        new MSBuildLogger(_baseProtocolClientManager, compileParams.OriginId, workspacePath)
+                    ],
+                },
+                []);
+
+            context.Logger.LogInformation("Start restore targets: {}", targetFiles);
+            var graphRestoreResult = buildManager.BuildRequest(new GraphBuildRequestData(graph, ["Restore"]));
+            context.Logger.LogInformation("Restore result: {}", graphRestoreResult.OverallResult);
+            buildResult &= (graphRestoreResult.OverallResult == BuildResultCode.Success);
+            context.Logger.LogInformation("Start building targets: {}", targetFiles);
+            var graphBuildResult = buildManager.BuildRequest(new GraphBuildRequestData(graph, ["Build"]));
+            context.Logger.LogInformation("Build result: {}", graphBuildResult.OverallResult);
+            buildResult &= (graphBuildResult.OverallResult == BuildResultCode.Success);
+            buildManager.EndBuild();
         }
 
         return Task.FromResult(new CompileResult