Skip to content

Commit f4a0651

Browse files
committed
Fix all dependency declarations in neoforge.mods.toml, properly address #182
This also fixes basically every issue I've had in the past regarding crashes with missing mod dependencies (instead of the regular starting screen for that), and anything else involving FML's mod loading order in general, since up until now FML assumed that MEGA had *no* dependencies to speak of. So why the fuck was I allowed all this time to have what I had prior?
1 parent 1a59598 commit f4a0651

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

src/main/java/gripe/_90/megacells/MEGACells.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public MEGACells(ModContainer container, IEventBus eventBus) {
6565
eventBus.addListener(MEGACells::initCapabilities);
6666
eventBus.addListener(MEGACells::initPacketHandlers);
6767

68-
eventBus.addListener(CompressionService::init);
68+
CompressionService.init();
6969
NeoForge.EVENT_BUS.addListener(MEGACells::initVillagerTrades);
7070

7171
container.registerConfig(ModConfig.Type.COMMON, MEGAConfig.SPEC);

src/main/java/gripe/_90/megacells/misc/CompressionService.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import net.minecraft.world.item.crafting.CraftingRecipe;
1919
import net.minecraft.world.item.crafting.RecipeManager;
2020
import net.minecraft.world.item.crafting.RecipeType;
21-
import net.neoforged.fml.event.lifecycle.FMLCommonSetupEvent;
2221
import net.neoforged.neoforge.common.NeoForge;
2322
import net.neoforged.neoforge.event.OnDatapackSyncEvent;
2423
import net.neoforged.neoforge.event.server.ServerStartedEvent;
@@ -49,10 +48,8 @@ public class CompressionService {
4948
*/
5049
private static final Map<Item, Integer> chainIndexes = new HashMap<>();
5150

52-
// FIXME: I don't think this is how grid services *should* be registered just to avoid current mod-loading order
53-
// shenanigans, but it'll do for now
54-
public static void init(FMLCommonSetupEvent setup) {
55-
setup.enqueueWork(() -> GridServices.register(DecompressionService.class, DecompressionService.class));
51+
public static void init() {
52+
GridServices.register(DecompressionService.class, DecompressionService.class);
5653

5754
NeoForge.EVENT_BUS.addListener(ServerStartedEvent.class, event -> {
5855
var server = event.getServer();

src/main/resources/META-INF/neoforge.mods.toml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,34 +19,35 @@ description = "ME Greater Accumulation Cells - For when kilobytes just won't do.
1919
[[mixins]]
2020
config = "megacells.mixins.json"
2121

22-
[[dependencies]]
22+
[[dependencies.megacells]]
2323
modId = "ae2"
2424
versionRange = "[19.2.9,)"
25+
ordering = "AFTER"
2526

26-
[[dependencies]]
27+
[[dependencies.megacells]]
2728
modId = "ae2wtlib"
2829
type = "optional"
2930

30-
[[dependencies]]
31+
[[dependencies.megacells]]
3132
modId = "appmek"
3233
type = "optional"
3334

34-
[[dependencies]]
35+
[[dependencies.megacells]]
3536
modId = "appbot"
3637
type = "optional"
3738

38-
[[dependencies]]
39+
[[dependencies.megacells]]
3940
modId = "arseng"
4041
type = "optional"
4142

42-
[[dependencies]]
43+
[[dependencies.megacells]]
4344
modId = "appflux"
4445
type = "optional"
4546

46-
[[dependencies]]
47+
[[dependencies.megacells]]
4748
modId = "appex"
4849
type = "optional"
4950

50-
[[dependencies]]
51+
[[dependencies.megacells]]
5152
modId = "appliede"
5253
type = "optional"

0 commit comments

Comments
 (0)