CheckboxSelectColumn, GroupItemMetadataProvider and DataView with grouping bugs

[igayevoy]

Some bugs that I've found:

1. When collapsing expanded group that have selected rows then the next rows are marked and styled as selected.
2. When collapsing or expanding selected group then it becomes unselected.
3. When all groups are collapsed the selection of all rows with the checkbox in header or selection of all rows in group does not marks and stylizes rows as selected.

They are reproduces on example page http://6pac.github.io/SlickGrid/examples/example-grouping-checkbox-row-select.html

[hakancunier]

Yes. I am facing same problem. +1

[ferman2147]

I couldn't reproduce the bug in Number 1 And on Number 2 rows still remain selected while the group header checkbox becomes unselected but Number 3 definitely looks like it needs a workaround...

[igayevoy]

After selecting a group:

After collapsing the selected group:

[ugurakca]

Yes exactly, captures are very clear about the issue. That's the point, collapsing and expending is broking the whole grid.

[hakancunier]

And also unless checkboxes same bug occurs as below;

[6pac]

Hi all. Will look at this on the weekend. I keep saying it, but I'm just really busy at the moment. I'm also a little surprised no-one has managed to fix it yet.

[hakancunier]

We tried many times and chased for several hours but unfortunately this is really annoying. There were some solutions but we were not sure about the regression and side effects. So we couldnt address a solution.

Also it may be a long-term bug from the original mleibman repository or a design issue.

[6pac]

These should be fixed now (latest release) 2.3.9. Just involved adding

dataView.syncGridSelection(grid, true, true);

after the grid.render(); in dataView.onRowCountChanged and dataView.onRowsChanged

EDIT: actually, it only needs to be added once during grid setup. My mistake. Will patch soon.

Check the wiki under 'Synchronizing selection & cell CSS styles' here.

I am investigating adding the functionality to select and deselect collapsed groups, but not quite there yet.

[hakancunier]

We are waiting for patch according to your edited comment. Thanks for work.

[6pac]

2.3.10 released. Still investigating 'select and deselect collapsed groups', but not quite there yet.

[hakancunier]

Just tried it but still same error occurred.

[6pac]

OK, can you get specific? It's working fine for me in Chrome. What browser are you using?

Here's the example: http://6pac.github.io/SlickGrid/examples/example-grouping-checkbox-row-select.html
Will add a link for it in the wiki example page.

[hakancunier]

Hello. Do we need to change dataview as you mentioned before or wait since "EDIT: actually, it only needs to be added once during grid setup. My mistake. Will patch soon."

[6pac]

No changes to core code. Just a one line addition to the example page itself.

When I mentioned dataView.onRowCountChanged and dataView.onRowsChanged, that was in the context of the dataview events that are handled in the example page.

[hakancunier]

Thanks. Adding dataView.onRowCountChanged and dataView.onRowsChanged seems solved the issue. But if there are many rows this really locks the screen. I think we should invoke syncselection in group toggle methods.