[Translator] Improve performance, remove (internally) duplicated call to ->slice($offset, 1)

Kocal · Kocal · commit 0bf904101656 · 2024-09-25T16:25:31.000+02:00
diff --git a/src/Translator/src/Intl/IntlMessageParser.php b/src/Translator/src/Intl/IntlMessageParser.php
@@ -12,6 +12,7 @@
 namespace Symfony\UX\Translator\Intl;
 
 use Symfony\Component\String\AbstractString;
+
 use function Symfony\Component\String\s;
 
 /**
@@ -883,7 +884,7 @@ private function char(): int
             throw new \OutOfBoundsException();
         }
 
-        $code = $this->message->slice($offset, 1)->codePointsAt(0)[0] ?? null;
+        $code = $this->message->codePointsAt($offset)[0] ?? null;
         if (null === $code) {
             throw new \Exception("Offset {$offset} is at invalid UTF-16 code unit boundary");
         }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespace Symfony\UX\Translator\Intl;`
`13`	`13`
`14`	`14`	`use Symfony\Component\String\AbstractString;`
	`15`	`+`
`15`	`16`	`use function Symfony\Component\String\s;`
`16`	`17`
`17`	`18`	`/**`
`@@ -883,7 +884,7 @@ private function char(): int`
`883`	`884`	`throw new \OutOfBoundsException();`
`884`	`885`	`}`
`885`	`886`
`886`		`- $code = $this->message->slice($offset, 1)->codePointsAt(0)[0] ?? null;`
	`887`	`+ $code = $this->message->codePointsAt($offset)[0] ?? null;`
`887`	`888`	`if (null === $code) {`
`888`	`889`	`throw new \Exception("Offset {$offset} is at invalid UTF-16 code unit boundary");`
`889`	`890`	`}`