Merge pull request #36 from priyanshujain/memory-system-redesign

Rename memory to history + build new memory system

Author: priyanshujain

CLAUDE.md

@@ -1,3 +1,9 @@
+## Project Guidelines
+
+- Do not call the task done until it is fully complete and tested.
+- Always write tests for new features and bug fixes.
+- Do not dismiss bug as a pre-existing" issue even if it was present before your change. It does not matter, it's still your responsibility to fix it. When you see a bug, fix it. Don't ignore it.
+
 ## Coding Guidelines
 
   - Keep code simple and easy to read.

README.md

@@ -28,7 +28,7 @@ Think of it like a meal kit instead of a pre-made meal. You get the ingredients
 
 | Component | What it does |
 |---|---|
-| **Sources** | Connectors for Gmail, WhatsApp, Apple Notes, and conversation memory |
+| **Sources** | Connectors for Gmail, WhatsApp, Apple Notes, and conversation history |
 | **Sync engine** | Background daemon (launchd/systemd) keeps your local data fresh |
 | **CLI** (`obk`) | Search, read, and send across all sources from the terminal |
 | **Assistant scaffolding** | Pre-configured Claude Code setup with skills for natural-language access |
@@ -114,8 +114,10 @@ Config and all synced data live under `~/.obk/` (override with `OBK_CONFIG_DIR`)
 │   └── data.db             # Synced messages
 ├── applenotes/
 │   └── data.db             # Synced notes
-└── memory/
-    └── data.db             # Conversation history
+├── history/
+│   └── data.db             # Conversation history
+└── user_memory/
+    └── data.db             # Personal facts about the user
 ```
 
 ## Prerequisites

agent/integration_test.go

@@ -62,7 +62,7 @@ func availableProviders(t *testing.T) []providerTestCase {
 		providers = append(providers, providerTestCase{
 			name:     "gemini",
 			provider: gemini.New(key),
-			model:    "gemini-2.0-flash",
+			model:    "gemini-2.5-flash",
 		})
 	}
 	if project := os.Getenv("GOOGLE_CLOUD_PROJECT"); project != "" {
@@ -74,7 +74,7 @@ func availableProviders(t *testing.T) []providerTestCase {
 		providers = append(providers, providerTestCase{
 			name:     "gemini-vertex",
 			provider: gemini.New("", gemini.WithVertexAI(project, region), gemini.WithTokenSource(provider.GcloudTokenSource(account))),
-			model:    "gemini-2.0-flash",
+			model:    "gemini-2.5-flash",
 		})
 	}
 
@@ -213,7 +213,7 @@ func TestIntegration_Streaming(t *testing.T) {
 			ch, err := tc.provider.StreamChat(ctx, provider.ChatRequest{
 				Model:     tc.model,
 				Messages:  []provider.Message{provider.NewTextMessage(provider.RoleUser, "Say 'test-stream-ok' and nothing else.")},
-				MaxTokens: 32,
+				MaxTokens: 256,
 			})
 			if err != nil {
 				t.Fatalf("StreamChat: %v", err)

agent/tools/skills_test.go

@@ -66,7 +66,7 @@ func TestSearchSkills(t *testing.T) {
 		Skills: []skills.IndexEntry{
 			{Name: "email-read", Description: "Search and read emails from Gmail inbox"},
 			{Name: "whatsapp-read", Description: "Search WhatsApp messages"},
-			{Name: "memory-read", Description: "Recall past conversations"},
+			{Name: "history-read", Description: "Recall past conversations"},
 		},
 	}
 	if err := skills.SaveIndex(idx); err != nil {
@@ -82,8 +82,8 @@ func TestSearchSkills(t *testing.T) {
 	if !strings.Contains(result, "email-read") {
 		t.Errorf("expected email-read in results: %q", result)
 	}
-	if strings.Contains(result, "memory-read") {
-		t.Errorf("unexpected memory-read in results: %q", result)
+	if strings.Contains(result, "history-read") {
+		t.Errorf("unexpected history-read in results: %q", result)
 	}
 }
 

assistant/.claude/settings.json

@@ -10,7 +10,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "obk memory capture"
+            "command": "obk history capture && obk memory extract &"
           }
         ]
       }

config/config.go

@@ -13,8 +13,9 @@ type Config struct {
 	Models       *ModelsConfig       `yaml:"models,omitempty"`
 	Gmail        *GmailConfig        `yaml:"gmail,omitempty"`
 	WhatsApp     *WhatsAppConfig     `yaml:"whatsapp,omitempty"`
-	Memory       *MemoryConfig       `yaml:"memory,omitempty"`
+	History      *HistoryConfig       `yaml:"history,omitempty"`
 	AppleNotes   *AppleNotesConfig   `yaml:"applenotes,omitempty"`
+	UserMemory   *UserMemoryConfig    `yaml:"user_memory,omitempty"`
 	Daemon       *DaemonConfig       `yaml:"daemon,omitempty"`
 	Integrations *IntegrationsConfig `yaml:"integrations,omitempty"`
 }
@@ -69,7 +70,11 @@ type GmailConfig struct {
 	Storage             StorageConfig `yaml:"storage,omitempty"`
 }
 
-type MemoryConfig struct {
+type HistoryConfig struct {
+	Storage StorageConfig `yaml:"storage,omitempty"`
+}
+
+type UserMemoryConfig struct {
 	Storage StorageConfig `yaml:"storage,omitempty"`
 }
 
@@ -137,7 +142,12 @@ func Default() *Config {
 				Driver: "sqlite",
 			},
 		},
-		Memory: &MemoryConfig{
+		History: &HistoryConfig{
+			Storage: StorageConfig{
+				Driver: "sqlite",
+			},
+		},
+		UserMemory: &UserMemoryConfig{
 			Storage: StorageConfig{
 				Driver: "sqlite",
 			},
@@ -168,11 +178,17 @@ func (c *Config) applyDefaults() {
 	if c.WhatsApp.Storage.Driver == "" {
 		c.WhatsApp.Storage.Driver = "sqlite"
 	}
-	if c.Memory == nil {
-		c.Memory = &MemoryConfig{}
+	if c.History == nil {
+		c.History = &HistoryConfig{}
+	}
+	if c.History.Storage.Driver == "" {
+		c.History.Storage.Driver = "sqlite"
+	}
+	if c.UserMemory == nil {
+		c.UserMemory = &UserMemoryConfig{}
 	}
-	if c.Memory.Storage.Driver == "" {
-		c.Memory.Storage.Driver = "sqlite"
+	if c.UserMemory.Storage.Driver == "" {
+		c.UserMemory.Storage.Driver = "sqlite"
 	}
 	if c.AppleNotes == nil {
 		c.AppleNotes = &AppleNotesConfig{}
@@ -206,11 +222,18 @@ func (c *Config) WhatsAppSessionDBPath() string {
 	return filepath.Join(SourceDir("whatsapp"), "session.db")
 }
 
-func (c *Config) MemoryDataDSN() string {
-	if c.Memory.Storage.DSN != "" {
-		return c.Memory.Storage.DSN
+func (c *Config) HistoryDataDSN() string {
+	if c.History.Storage.DSN != "" {
+		return c.History.Storage.DSN
+	}
+	return filepath.Join(SourceDir("history"), "data.db")
+}
+
+func (c *Config) UserMemoryDataDSN() string {
+	if c.UserMemory.Storage.DSN != "" {
+		return c.UserMemory.Storage.DSN
 	}
-	return filepath.Join(SourceDir("memory"), "data.db")
+	return filepath.Join(SourceDir("user_memory"), "data.db")
 }
 
 func (c *Config) AppleNotesDataDSN() string {