fix(tools): fix data race in mockInteractor used by GWS test

Added mutex to mockInteractor and a linkCh channel so
TestGWSExecute_MissingScopeSignaled no longer polls shared state.

Author: priyanshujain

agent/tools/guard_test.go

@@ -3,29 +3,42 @@ package tools
 import (
 	"context"
 	"errors"
+	"sync"
 	"testing"
 )
 
 type mockInteractor struct {
+	mu         sync.Mutex
 	notified   []string
 	links      []struct{ text, url string }
 	approvals  []string
 	approveAll bool
 	approveErr error
 	notifyErr  error
+	linkCh     chan struct{ text, url string } // optional signal for NotifyLink
 }
 
 func (m *mockInteractor) Notify(msg string) error {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	m.notified = append(m.notified, msg)
 	return m.notifyErr
 }
 
 func (m *mockInteractor) NotifyLink(text, url string) error {
+	m.mu.Lock()
 	m.links = append(m.links, struct{ text, url string }{text, url})
+	ch := m.linkCh
+	m.mu.Unlock()
+	if ch != nil {
+		ch <- struct{ text, url string }{text, url}
+	}
 	return nil
 }
 
 func (m *mockInteractor) RequestApproval(desc string) (bool, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
 	m.approvals = append(m.approvals, desc)
 	if m.approveErr != nil {
 		return false, m.approveErr

agent/tools/gws_execute_test.go

@@ -195,7 +195,8 @@ func TestGWSExecute_MissingScopeSignaled(t *testing.T) {
 		TokenDBPath:     dbPath,
 	})
 	bridge := NewTokenBridge(g, "user@test.com")
-	inter := &mockInteractor{approveAll: false}
+	linkCh := make(chan struct{ text, url string }, 1)
+	inter := &mockInteractor{approveAll: false, linkCh: linkCh}
 	runner := &mockRunner{outputs: map[string]string{"calendar events.list": `{"items":[]}`}}
 
 	waiter := google.NewScopeWaiter()
@@ -230,22 +231,16 @@ func TestGWSExecute_MissingScopeSignaled(t *testing.T) {
 		close(done)
 	}()
 
-	// Wait for the auth link to be sent.
-	deadline := time.After(3 * time.Second)
-	for {
-		if len(inter.links) > 0 {
-			break
-		}
-		select {
-		case <-deadline:
-			t.Fatal("timed out waiting for auth link")
-		default:
-			time.Sleep(10 * time.Millisecond)
-		}
+	// Wait for the auth link to be sent via channel (race-free).
+	var link struct{ text, url string }
+	select {
+	case link = <-linkCh:
+	case <-time.After(3 * time.Second):
+		t.Fatal("timed out waiting for auth link")
 	}
 
 	// Extract state from the auth link URL.
-	linkURL := inter.links[0].url
+	linkURL := link.url
 	stateIdx := strings.Index(linkURL, "state=")
 	if stateIdx < 0 {
 		t.Fatal("auth link missing state param")