Improved the handling of launch timeout

User-defined timeout is now used. The timeout warning has been improved, the offending process can now be killed to prevent entering a limbo state. PID is now obtained immediately after the process is started.

Author: daviunic

86BoxManager/frmMain.cs

@@ -519,12 +519,13 @@ private void VMStart()
                     }
 
                     p.Start();
-                    bool initSuccess = p.WaitForInputIdle(5000); //Wait 5 seconds so hWnd can be obtained
+                    vm.Pid = p.Id;
+                    bool initSuccess = p.WaitForInputIdle(launchTimeout); //Wait 5 seconds so hWnd can be obtained
 
                     if (!p.MainWindowHandle.Equals(IntPtr.Zero) && initSuccess)
                     {
                         vm.hWnd = p.MainWindowHandle; //Get the window handle of the newly created process
-                        vm.Pid = p.Id; //Assign the pid to the VM
+                       //vm.Pid = p.Id; //Assign the pid to the VM
                         vm.Status = VM.STATUS_RUNNING;
                         lstVMs.SelectedItems[0].SubItems[1].Text = vm.GetStatusString();
                         lstVMs.SelectedItems[0].ImageIndex = 1;
@@ -557,8 +558,11 @@ private void VMStart()
                         btnConfigure.Enabled = true;
                     }
                     else
-                    {
-                        MessageBox.Show("The 86Box process did not initialize in time. This could be due to poor system performance, or it could indicate a bug. Consider contacting the developer.", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                    { //Inform the user what happened
+                        MessageBox.Show("The 86Box process did not initialize in time. This usually happens due to poor system performance.\n\nIf you see this message often, consider increasing the timeout value in the settings. It's recommended that you kill the associated 86Box process now.", "Error", MessageBoxButtons.OK, MessageBoxIcon.Warning);
+
+                        //And try to stop the process so we don't end up in limbo land...
+                        VMKill();
                     }
                 }
             }