Improve effect handling in LEDNETWFLight and Model0x56

- Update available property to use 'is not None' for clarity.
- Add logging for unknown effects in LEDNETWFLight.
- Handle unknown effects gracefully in Model0x56's set_effect method.

Author: 8none1

custom_components/lednetwf_ble/light.py

@@ -51,7 +51,7 @@ def __init__(
 
     @property
     def available(self):
-        return self._instance.is_on != None
+        return self._instance.is_on is not None
 
     @property
     def brightness(self):
@@ -181,7 +181,12 @@ async def async_turn_on(self, **kwargs: Any) -> None:
         elif ATTR_RGB_COLOR in kwargs:
             await self._instance.set_rgb_color(kwargs[ATTR_RGB_COLOR], on_brightness)
         elif ATTR_EFFECT in kwargs and kwargs[ATTR_EFFECT] != EFFECT_OFF:
-            await self._instance.set_effect(kwargs[ATTR_EFFECT], on_brightness)
+            effect = kwargs[ATTR_EFFECT]
+            # Don't try to set unknown effects
+            if effect.startswith("Unknown Effect"):
+                LOGGER.warning(f"Cannot set unknown effect: {effect}. Ignoring.")
+            else:
+                await self._instance.set_effect(effect, on_brightness)
         self.async_write_ha_state()
 
     async def async_turn_off(self, **kwargs: Any) -> None:
@@ -213,5 +218,5 @@ def update_ha_state(self) -> None:
         #     self._color_mode = ColorMode.RGB
         elif self.color_temp_kelvin is not None:
             self._color_mode = ColorMode.COLOR_TEMP
-        self.available = self._instance.is_on != None
+        self.available = self._instance.is_on is not None
         self.async_write_ha_state()

custom_components/lednetwf_ble/models/model_0x56.py

@@ -164,9 +164,17 @@ def set_color(self, hs_color, brightness):
 
     def set_effect(self, effect, brightness):
         # Returns the byte array to set the effect
-        LOGGER.debug(f"Setting effect: {effect}")      
+        LOGGER.debug(f"Setting effect: {effect}")
+        
+        # Handle unknown effects gracefully
+        if effect.startswith("Unknown Effect"):
+            LOGGER.warning(f"Attempt to set unknown effect: {effect}. Ignoring.")
+            return None
+        
         if effect not in EFFECT_LIST_0x56:
-            raise ValueError(f"Effect '{effect}' not in EFFECTS_LIST_0x53")
+            LOGGER.error(f"Effect '{effect}' not in EFFECT_LIST_0x56")
+            raise ValueError(f"Effect '{effect}' not in EFFECT_LIST_0x56")
+        
         self.effect = effect
         self.brightness = brightness
         #self.color_mode  = XXX ColorMode.BRIGHTNESS # Don't set this here, we might want to change the color of the effects?