Ban message rework suggestion

[thesecondpioneer]

Encountered this problem (#614) too, was able to resolve it thankfully.

One thing i should note is that "thank you for playing" on your file server's landing page and a bunch of vulnerability scanning patterns in your reverse proxy and copyparty logs scream "your site got defaced and the hackers/script left you a note", if you are not familiar with how the 403 page when you are banned looks (i suspect a lot of people are not familiar with a ban message for their personal file server).

I understand that leaving any sort of mark in the ban message that leads to copyparty might not be great for security, but i suspect it's fairly easy for anyone poking around to see they tried accessing copyparty and got banned, by tracing the logs. On the other hand, "thank you for playing error" and "thank you for playing 403" google searches don't lead to copyparty. For the first hour of figuring this problem out, i was confident the problem was my reverse proxy, since vps ip and lan ip access worked totally fine.

I suggest reworking the ban 403 page to somehow reflect that it's copyparty's default ban message

Thank you.

[9001]

For the first hour of figuring this problem out, i was confident the problem was my reverse proxy

sorry for the detour!

the message is currently: "thank you for playing (see serverlog and readme)"

perhaps this would be better: "rejected (see fileserver log and readme)"

[Scotsguy]

I think the message I would expect to see, since this is effectively a rate limit ban, would be "too many requests ([...])"
rejected is a bit too generic to be helpful for debugging, while too many requests intuitively brings up rate limits -> ip ban -> reverse proxy imo

[thesecondpioneer]

Oh, so it's already a different message from just "thank you for playing", must've not updated in a while. Is it the same for the docker release?
But yeah, a pointer to it being a file server problem would be much appreciated by any future users i think.

[9001]

the message was reworded into "thank you for playing (see fileserver log and readme)" which should hopefully help