fix: lazy SSH connection to host in testdevice

Previously, newHost dialed SSH immediately at device initialization,
causing failures when the host OS hadn't finished booting yet or when
running BMC-only suites that don't need host access.

Now the SSH connection is established on first use via ExecuteCommandLine.

Signed-off-by: llogen <christoph.lange@blindspot.software>

Author: llogen

pkg/testdevice/host.go

@@ -2,15 +2,18 @@ package testdevice
 
 import (
 	"fmt"
+	"log"
 	"os"
 
 	"github.com/9elements/bmc-test-go/pkg/configuration"
 	"golang.org/x/crypto/ssh"
 )
 
 type Host struct {
-	Name string
-	RemoteConn
+	Name       string
+	hostport   string
+	sshConfig  *ssh.ClientConfig
+	remoteConn *RemoteConn
 }
 
 func newHost(sshPrivKeyPath string, hostCfg configuration.Host) (*Host, error) {
@@ -38,25 +41,45 @@ func newHost(sshPrivKeyPath string, hostCfg configuration.Host) (*Host, error) {
 		}
 	}
 
-	hostport := fmt.Sprintf("%s:%s", hostCfg.IP, hostCfg.SSHPort)
-	client, err := ssh.Dial("tcp", hostport, sshConfig)
+	return &Host{
+		Name:      hostCfg.Name,
+		hostport:  fmt.Sprintf("%s:%s", hostCfg.IP, hostCfg.SSHPort),
+		sshConfig: sshConfig,
+	}, nil
+}
+
+func (h *Host) connect() error {
+	if h.remoteConn != nil {
+		return nil
+	}
+	client, err := ssh.Dial("tcp", h.hostport, h.sshConfig)
 	if err != nil {
-		return nil, err
+		return err
 	}
-
-	con := RemoteConn{
-		IP:       hostCfg.IP,
-		User:     hostCfg.Username,
-		Password: "",
-		client:   client,
+	h.remoteConn = &RemoteConn{
+		IP:     h.hostport,
+		User:   h.sshConfig.User,
+		client: client,
 	}
-	return &Host{Name: hostCfg.Name, RemoteConn: con}, nil
+	return nil
 }
 
 func (h *Host) Close() error {
-	return h.RemoteConn.Close()
+	if h.remoteConn == nil {
+		return nil
+	}
+	return h.remoteConn.Close()
 }
 
 func (h *Host) ExecuteCommandLine(cmd string, args ...string) ([]byte, error) {
-	return h.RemoteConn.ExecuteCmdline(cmd, args...)
+	if err := h.connect(); err != nil {
+		return nil, err
+	}
+	defer func() {
+		if err := h.remoteConn.Close(); err != nil {
+			log.Print(err)
+		}
+		h.remoteConn = nil
+	}()
+	return h.remoteConn.ExecuteCmdline(cmd, args...)
 }