feat(cmd): support multiple configuration files

- this should hopefully help to reduce copy-pasting for users
- I just changed 2 example test to test this feature
- the difference is order of the configuration files, for coreboot the
  target is in first config, while for linux it is in the second

Signed-off-by: AtomicFS <vojtech.vesely@9elements.com>

Author: AtomicFS

.github/workflows/example.yml

@@ -156,12 +156,15 @@ jobs:
         uses: ./
         # uses: 9elements/firmware-action
         with:
-          config: 'tests/example_config__coreboot.json'
+          config: |-
+            tests/example_config__coreboot.json
+            tests/example_config__uroot.json
           target: 'coreboot-example'
           recursive: 'false'
           compile: ${{ needs.changes.outputs.compile }}
         env:
           COREBOOT_VERSION: ${{ matrix.coreboot-version }}
+          UROOT_VERSION: "dummy"
 
       - name: Get artifacts
         uses: actions/upload-artifact@v4
@@ -229,13 +232,16 @@ jobs:
         uses: ./
         # uses: 9elements/firmware-action
         with:
-          config: 'tests/example_config__linux.json'
+          config: |-
+            tests/example_config__uroot.json
+            tests/example_config__linux.json
           target: 'linux-example'
           recursive: 'false'
           compile: ${{ needs.changes.outputs.compile }}
         env:
           LINUX_VERSION: ${{ matrix.linux-version }}
           SYSTEM_ARCH: ${{ matrix.arch }}
+          UROOT_VERSION: "dummy"
 
       - name: Get artifacts
         uses: actions/upload-artifact@v4

cmd/firmware-action/main.go

@@ -12,6 +12,7 @@ import (
 	"log/slog"
 	"os"
 	"regexp"
+	"strings"
 
 	"github.com/9elements/firmware-action/cmd/firmware-action/filesystem"
 	"github.com/9elements/firmware-action/cmd/firmware-action/logging"
@@ -42,7 +43,7 @@ var CLI struct {
 	Indent bool `default:"false" help:"enable indentation for JSON output"`
 	Debug  bool `default:"false" help:"increase verbosity"`
 
-	Config string `type:"path" required:"" default:"${config_file}" help:"Path to configuration file"`
+	Config []string `type:"path" required:"" default:"${config_file}" help:"Path to configuration file, supports multiple flags to use multiple configuration files"`
 
 	Build struct {
 		Target    string `required:"" help:"Select which target to build, use ID from configuration file"`
@@ -76,7 +77,7 @@ func run(ctx context.Context) error {
 	)
 	slog.Info(
 		fmt.Sprintf("Running in %s mode", mode),
-		slog.String("input/config", CLI.Config),
+		slog.Any("input/config", CLI.Config),
 		slog.String("input/target", CLI.Build.Target),
 		slog.Bool("input/recursive", CLI.Build.Recursive),
 	)
@@ -108,7 +109,7 @@ func run(ctx context.Context) error {
 			patterSub := regexp.MustCompile(`^\-[\d\w]* `)
 			slog.Warn(
 				"Git submodule seems to be uninitialized",
-				slog.String("suggestion", "run 'git submodule update --depth 0 --init --recursive --checkout'"),
+				slog.String("suggestion", "run 'git submodule update --depth 1 --init --recursive --checkout'"),
 				slog.String("offending_submodule", patterSub.ReplaceAllString(v, "")),
 			)
 		}
@@ -117,7 +118,7 @@ submodule_out:
 
 	// Parse configuration file
 	var myConfig *recipes.Config
-	myConfig, err = recipes.ReadConfig(CLI.Config)
+	myConfig, err = recipes.ReadConfigs(CLI.Config)
 	if err != nil {
 		return err
 	}
@@ -189,7 +190,7 @@ func parseCli() (string, error) {
 
 	case "generate-config":
 		// Check if config file exists
-		err := filesystem.CheckFileExists(CLI.Config)
+		err := filesystem.CheckFileExists(CLI.Config[0])
 		if !errors.Is(err, os.ErrNotExist) {
 			// The file exists, or is directory, or some other problem
 			slog.Error(
@@ -222,7 +223,7 @@ func parseCli() (string, error) {
 
 		// Write to file
 		slog.Info(fmt.Sprintf("Generating configuration file at: %s", CLI.Config))
-		if err := os.WriteFile(CLI.Config, jsonString, 0o666); err != nil {
+		if err := os.WriteFile(CLI.Config[0], jsonString, 0o666); err != nil {
 			slog.Error(
 				"Unable to write generated configuration into file",
 				slog.Any("error", err),
@@ -253,7 +254,7 @@ func parseGithub() (string, error) {
 	action := githubactions.New()
 	regexTrue := regexp.MustCompile(`(?i)true`)
 
-	CLI.Config = action.GetInput("config")
+	CLI.Config = strings.Split(action.GetInput("config"), "\n")
 	CLI.Build.Target = action.GetInput("target")
 	CLI.Build.Recursive = regexTrue.MatchString(action.GetInput("recursive"))
 	CLI.JSON = regexTrue.MatchString(action.GetInput("json"))

cmd/firmware-action/recipes/config.go

@@ -230,6 +230,78 @@ func (c Config) AllModules() map[string]FirmwareModule {
 	return modules
 }
 
+func checkIfModuleExists(ok bool, key string) {
+	if ok {
+		slog.Warn("Module already exists in configuration, and will be overwritten",
+			slog.String("module_name", key),
+			slog.String("suggestion", "Make sure each module has unique name, not only per single configuration file but across all configuration files."),
+		)
+	}
+}
+
+// Merge method will take other Config instance and adopt all of its modules
+func (c Config) Merge(other Config) (Config, error) {
+	// Not sure of there is cleaner way to do this :/
+
+	for key, value := range other.Coreboot {
+		if len(c.Coreboot) == 0 {
+			c.Coreboot = map[string]CorebootOpts{}
+		}
+		_, ok := c.Coreboot[key]
+		checkIfModuleExists(ok, key)
+		c.Coreboot[key] = value
+	}
+	for key, value := range other.Linux {
+		if len(c.Linux) == 0 {
+			c.Linux = map[string]LinuxOpts{}
+		}
+		_, ok := c.Linux[key]
+		checkIfModuleExists(ok, key)
+		c.Linux[key] = value
+	}
+	for key, value := range other.Edk2 {
+		if len(c.Edk2) == 0 {
+			c.Edk2 = map[string]Edk2Opts{}
+		}
+		_, ok := c.Edk2[key]
+		checkIfModuleExists(ok, key)
+		c.Edk2[key] = value
+	}
+	for key, value := range other.FirmwareStitching {
+		if len(c.FirmwareStitching) == 0 {
+			c.FirmwareStitching = map[string]FirmwareStitchingOpts{}
+		}
+		_, ok := c.FirmwareStitching[key]
+		checkIfModuleExists(ok, key)
+		c.FirmwareStitching[key] = value
+	}
+	for key, value := range other.URoot {
+		if len(c.URoot) == 0 {
+			c.URoot = map[string]URootOpts{}
+		}
+		_, ok := c.URoot[key]
+		checkIfModuleExists(ok, key)
+		c.URoot[key] = value
+	}
+	for key, value := range other.Universal {
+		if len(c.Universal) == 0 {
+			c.Universal = map[string]UniversalOpts{}
+		}
+		_, ok := c.Universal[key]
+		checkIfModuleExists(ok, key)
+		c.Universal[key] = value
+	}
+	for key, value := range other.UBoot {
+		if len(c.UBoot) == 0 {
+			c.UBoot = map[string]UBootOpts{}
+		}
+		_, ok := c.UBoot[key]
+		checkIfModuleExists(ok, key)
+		c.UBoot[key] = value
+	}
+	return c, nil
+}
+
 // FirmwareModule interface
 type FirmwareModule interface {
 	GetDepends() []string
@@ -273,6 +345,26 @@ func FindAllEnvVars(text string) []string {
 	return result
 }
 
+// ReadConfigs is for reading and parsing multiple JSON configuration files into single Config struct
+func ReadConfigs(filepaths []string) (*Config, error) {
+	var allConfigs Config
+	for _, filepath := range filepaths {
+		trimmedFilepath := strings.TrimSpace(filepath)
+		slog.Debug("Reading config",
+			slog.String("path", trimmedFilepath),
+		)
+		payload, err := ReadConfig(trimmedFilepath)
+		if err != nil {
+			return nil, err
+		}
+		allConfigs, err = allConfigs.Merge(*payload)
+		if err != nil {
+			return nil, err
+		}
+	}
+	return &allConfigs, nil
+}
+
 // ReadConfig is for reading and parsing JSON configuration file into Config struct
 func ReadConfig(filepath string) (*Config, error) {
 	// Read JSON file