MLBUF artifact #1
Description
Hi --
Here are my comments..
1. Build OpenROAD
This "git link" does not work well. (Recommend to use the following command "git clone --branch mlbuf-public-release https://github.com/ytliu8464/OpenROAD-flow-scripts.git")
'''
git clone --recursive -b mlbuf-public-release git@github.com:ytliu8464/OpenROAD.git
Cloning into 'OpenROAD'...
The authenticity of host 'github.com (20.200.245.247)' can't be established.
ECDSA key fingerprint is SHA256:p2QAMXNIC1TJYWeIOttrVc98/R1BUFWu3/LiyKgUfQM.
Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
Warning: Permanently added 'github.com,20.200.245.247' (ECDSA) to the list of known hosts.
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
'''
2. Run MLBuf-RePlAce
The path for "run_replace_mlbuf.tcl" is "${PROJ_DIR}/scripts/OR_scripts/${DESIGN_NAME}",
so the path within the .sh file should be fixed. (The same applies to other .sh files.)
3. Build ORFS
I would recommand to mention
"git clone --branch mlbuf-orfs-public https://github.com/ytliu8464/OpenROAD-flow-scripts.git"
3. ETC
For the consistency, I would suggest fix those commands. (Minor comments)
scripts/OR_scripts/{design}/{method}.odb --> scripts/OR_scripts/${DESIGN_NAME}/${METHOD}.odb
source OpenROAD-flow-scripts/flow/mlbuf_run_scripts/run_${METHOD}.sh
mlbuf_run_scripts/logs/${PLATFORM}/${DESIGN_NAME}/${METHOD}/*.log
Best,
Seonghyeon