Skip to content

Commit b0cf864

Browse files
Jacobluke-JAnns98
authored andcommitted
keep delta g same as deltadelta for prop
1 parent 0206e46 commit b0cf864

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

dabest/_stats_tools/confint_2group_diff.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,7 @@ def delta2_bootstrap_loop(x1, x2, x3, x4, resamples, pooled_sd, rng_seed, is_pai
167167
"""
168168
np.random.seed(rng_seed)
169169
deltadelta = np.empty(resamples)
170-
171-
# For proportional data, we don't need out_delta_g
172-
out_delta_g = np.empty(resamples) if not proportional else deltadelta # Use deltadelta as dummy
170+
out_delta_g = np.empty(resamples)
173171

174172
n1, n2, n3, n4 = len(x1), len(x2), len(x3), len(x4)
175173
if is_paired and (n1 != n2 or n3 != n4):
@@ -197,8 +195,8 @@ def delta2_bootstrap_loop(x1, x2, x3, x4, resamples, pooled_sd, rng_seed, is_pai
197195
delta_delta = delta_2 - delta_1
198196

199197
deltadelta[i] = delta_delta
200-
if not proportional:
201-
out_delta_g[i] = delta_delta / pooled_sd
198+
199+
out_delta_g[i] = delta_delta if proportional else delta_delta/pooled_sd
202200

203201
return out_delta_g, deltadelta
204202

0 commit comments

Comments
 (0)