Skip to content

Commit 7fb4eee

Browse files
authored
Merge pull request #187 from teunbrand/compat_ggplot2_400
ggplot2 transitioned from S3 class to S7 class, hence affecting several functions including ``` expect_s3_class(p, "ggplot") expect_length(p, 11) expect_type(p, "list") ``` which directly affects the testing script for function add_scaling_component_to_delta_plot(). The output of this function is a list, and the first element of the list is a ggplot2 object.
2 parents 88768ac + 7912a22 commit 7fb4eee

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Imports:
4949
dplyr,
5050
effsize,
5151
ggbeeswarm,
52-
ggplot2 (>= 3.5.1),
52+
ggplot2 (>= 3.5.2),
5353
ggsci,
5454
grid,
5555
magrittr,

tests/testthat/test_002_plot_components.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe("Testing add_scaling_component_to_delta_plot function", {
1212
expect_type(result, "list")
1313
expect_equal(length(result), 3) # 3 components returned
1414
# Check delta_plot component
15-
expect_type(result[[1]], "list")
15+
expect_true(ggplot2::is_ggplot(result[[1]]))
1616
# TODO Add specific expectations to check if the components are created correctly
1717
})
1818
})

0 commit comments

Comments
 (0)