fixup! fixup! Prioritize private channels when relaying payments

Author: t-bast

eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala

@@ -388,10 +388,10 @@ class ChannelRelay private(nodeParams: NodeParams,
       .sortWith {
         // we always prioritize private channels to avoid exhausting our public channels and disabling them or lowering their htlc_maximum_msat
         case (channel1, channel2) if channel1.commitments.announceChannel != channel2.commitments.announceChannel => !channel1.commitments.announceChannel
-        // otherwise, we use the lowest available capacity to ensure we keep high-capacity channels for big payments
-        case (channel1, channel2) if channel1.commitments.capacity != channel2.commitments.capacity => channel1.commitments.capacity <= channel2.commitments.capacity
-        // otherwise, we use the lowest available balance to increase our incoming liquidity
-        case (channel1, channel2) => channel1.commitments.availableBalanceForSend <= channel2.commitments.availableBalanceForSend
+        // otherwise, we use the lowest available balance to enusre we keep higher balances for larger payments
+        case (channel1, channel2) if channel1.commitments.availableBalanceForSend != channel2.commitments.availableBalanceForSend => channel1.commitments.availableBalanceForSend <= channel2.commitments.availableBalanceForSend
+        // otherwise, we use the lowest available capacity as a last discriminator to have a fully defined sorting algorithm
+        case (channel1, channel2) => channel1.commitments.capacity <= channel2.commitments.capacity
       }.headOption match {
       case Some(channel) => Some(channel)
       case None =>