Sanitize logs (#246)

* Don't print seed with LocalKeyManager
* Don't log ping and pong

Author: t-bast

src/commonMain/kotlin/fr/acinq/eclair/crypto/LocalKeyManager.kt

@@ -9,11 +9,13 @@ import fr.acinq.eclair.transactions.Transactions
 data class LocalKeyManager(val seed: ByteVector, val chainHash: ByteVector32) : KeyManager {
 
     private val master = DeterministicWallet.generate(seed)
-
     override val nodeKey: DeterministicWallet.ExtendedPrivateKey = derivePrivateKey(master, nodeKeyBasePath(chainHash))
-
     override val nodeId: PublicKey get() = nodeKey.publicKey
 
+    override fun toString(): String {
+        return "LocalKeyManager(seed=xxx,chainHash=$chainHash)"
+    }
+
     private fun internalKeyPath(channelKeyPath: List<Long>, index: Long): List<Long> = channelKeyBasePath(chainHash) + channelKeyPath + index
 
     private fun internalKeyPath(channelKeyPath: KeyPath, index: Long): List<Long> = internalKeyPath(channelKeyPath.path, index)

src/commonMain/kotlin/fr/acinq/eclair/io/Peer.kt

@@ -56,10 +56,10 @@ data class PaymentNotSent(val request: SendPayment, val reason: OutgoingPaymentF
 data class PaymentSent(val request: SendPayment, val payment: OutgoingPayment) : PeerListenerEvent()
 data class ChannelClosing(val channelId: ByteVector32) : PeerListenerEvent()
 
-object SendSwapInRequest: PeerEvent()
-data class SwapInResponseEvent(val swapInResponse: SwapInResponse): PeerListenerEvent()
-data class SwapInPendingEvent(val swapInPending: SwapInPending): PeerListenerEvent()
-data class SwapInConfirmedEvent(val swapInConfirmed: SwapInConfirmed): PeerListenerEvent()
+object SendSwapInRequest : PeerEvent()
+data class SwapInResponseEvent(val swapInResponse: SwapInResponse) : PeerListenerEvent()
+data class SwapInPendingEvent(val swapInPending: SwapInPending) : PeerListenerEvent()
+data class SwapInConfirmedEvent(val swapInConfirmed: SwapInConfirmed) : PeerListenerEvent()
 
 @OptIn(ExperimentalStdlibApi::class, ExperimentalCoroutinesApi::class, ExperimentalTime::class)
 class Peer(
@@ -269,12 +269,14 @@ class Peer(
                 sendToPeer(ping)
             }
         }
+
         suspend fun checkPaymentsTimeout() {
             while (isActive) {
                 delay(30.seconds)
                 input.send(CheckPaymentsTimeout)
             }
         }
+
         suspend fun listen() {
             try {
                 while (isActive) {
@@ -287,10 +289,11 @@ class Peer(
                 closeSocket()
             }
         }
+
         suspend fun respond() {
             // Reset the output channel to avoid sending obsolete messages
             output = Channel(BUFFERED)
-            for(msg in output) send(msg)
+            for (msg in output) send(msg)
         }
 
         launch { doPing() }
@@ -308,8 +311,8 @@ class Peer(
 
     suspend fun sendToPeer(msg: LightningMessage) {
         val encoded = LightningMessage.encode(msg)
-        // Avoids polluting the logs with pongs
-        if (msg !is Pong) logger.info { "n:$remoteNodeId sending $msg" }
+        // Avoids polluting the logs with pings/pongs
+        if (msg !is Ping && msg !is Pong) logger.info { "n:$remoteNodeId sending $msg" }
         if (!output.isClosedForSend) output.send(encoded)
     }
 
@@ -481,7 +484,7 @@ class Peer(
         when {
             event is BytesReceived -> {
                 val msg = LightningMessage.decode(event.data)
-                msg?.let { logger.info { "n:$remoteNodeId received $it" } }
+                msg?.let { if (it !is Ping && it !is Pong) logger.info { "n:$remoteNodeId received $it" } }
                 when {
                     msg is Init -> {
                         val theirFeatures = Features(msg.features)