Use current timestamp in invoice preimage #256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case our random number generator completely fails, we may end up generating the same payment preimage for unrelated payments. To mitigate that, we use the current time at the end of the preimage. This still leaves at least 192 bits of randomness which is more than enough.
|
Closing in favor of #258 We don't want our preimages to look different from other wallet's preimages, because it would give intermediate node information about the recipient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case our random number generator completely fails, we may end up generating the same payment preimage for unrelated payments.
To mitigate that, we use the current time at the end of the preimage.
This still leaves at least 192 bits of randomness which is more than enough.
NB: wallets who want to leverage this (e.g. Phoenix) will need to call this new function instead of
randomBytes32()when generating an invoice.