test: fix contribute command tests for validation feature

Updated tests to mock SpeckitValidator and support new validation flow:
- Added create_passing_validation_result() helper
- Mocked SpeckitValidator in all affected tests
- Added tests for --check-only flag (passing and failing)
- All 14 tests now passing

Tests fixed:
- test_contribute_interactive_full_flow
- test_contribute_with_detected_commands
- test_contribute_custom_commands

Tests added:
- test_contribute_check_only_passing
- test_contribute_check_only_failing

Author: NeilJo-GY

tests/unit/test_cli_contribute.py

@@ -7,10 +7,43 @@
 from typer.testing import CliRunner
 
 from metaspec.cli.main import app
+from metaspec.validation import ValidationCheck, ValidationResult
 
 runner = CliRunner()
 
 
+def create_passing_validation_result() -> ValidationResult:
+    """Create a passing validation result for tests."""
+    checks = [
+        ValidationCheck(
+            name="pyproject.toml",
+            passed=True,
+            message="Valid (name: test, version: 1.0.0)",
+        ),
+        ValidationCheck(
+            name="README.md",
+            passed=True,
+            message="Found (100 characters)",
+        ),
+        ValidationCheck(
+            name="LICENSE",
+            passed=True,
+            message="Found",
+        ),
+        ValidationCheck(
+            name="CLI Entry Point",
+            passed=True,
+            message="Found: test-command",
+        ),
+        ValidationCheck(
+            name="GitHub Repository",
+            passed=True,
+            message="Found: https://github.com/test/repo",
+        ),
+    ]
+    return ValidationResult(checks=checks, passed=True, warnings=[])
+
+
 class TestContributeCommand:
     """Tests for contribute command."""
 
@@ -54,6 +87,7 @@ def test_contribute_command_description(self) -> None:
         assert result.exit_code == 0
         assert "community" in result.stdout.lower() or "registry" in result.stdout.lower()
 
+    @patch("metaspec.cli.contribute.SpeckitValidator")
     @patch("metaspec.cli.contribute.shutil.which")
     @patch("metaspec.cli.contribute.CommunityRegistry")
     @patch("metaspec.cli.contribute.Prompt.ask")
@@ -66,8 +100,14 @@ def test_contribute_interactive_full_flow(
         mock_prompt: MagicMock,
         mock_registry_class: MagicMock,
         mock_which: MagicMock,
+        mock_validator_class: MagicMock,
     ) -> None:
         """Test complete interactive contribution flow."""
+        # Mock validation passing
+        mock_validator = MagicMock()
+        mock_validator.validate.return_value = create_passing_validation_result()
+        mock_validator_class.return_value = mock_validator
+
         # Mock command exists
         mock_which.return_value = "/usr/local/bin/my-spec-kit"
 
@@ -102,6 +142,7 @@ def test_contribute_interactive_full_flow(
         assert result.exit_code == 0
         assert "Generated metadata" in result.stdout or mock_file.called
 
+    @patch("metaspec.cli.contribute.SpeckitValidator")
     @patch("metaspec.cli.contribute.shutil.which")
     @patch("metaspec.cli.contribute.CommunityRegistry")
     @patch("metaspec.cli.contribute.Prompt.ask")
@@ -114,8 +155,14 @@ def test_contribute_with_detected_commands(
         mock_prompt: MagicMock,
         mock_registry_class: MagicMock,
         mock_which: MagicMock,
+        mock_validator_class: MagicMock,
     ) -> None:
         """Test contribution uses detected commands."""
+        # Mock validation passing
+        mock_validator = MagicMock()
+        mock_validator.validate.return_value = create_passing_validation_result()
+        mock_validator_class.return_value = mock_validator
+
         # Mock command exists
         mock_which.return_value = "/usr/local/bin/test-kit"
 
@@ -172,6 +219,7 @@ def test_contribute_command_not_in_path_continue(
         # Should exit
         assert result.exit_code == 1
 
+    @patch("metaspec.cli.contribute.SpeckitValidator")
     @patch("metaspec.cli.contribute.shutil.which")
     @patch("metaspec.cli.contribute.CommunityRegistry")
     @patch("metaspec.cli.contribute.Prompt.ask")
@@ -184,8 +232,14 @@ def test_contribute_custom_commands(
         mock_prompt: MagicMock,
         mock_registry_class: MagicMock,
         mock_which: MagicMock,
+        mock_validator_class: MagicMock,
     ) -> None:
         """Test contribution with custom commands instead of detected ones."""
+        # Mock validation passing
+        mock_validator = MagicMock()
+        mock_validator.validate.return_value = create_passing_validation_result()
+        mock_validator_class.return_value = mock_validator
+
         # Mock command exists
         mock_which.return_value = "/usr/bin/custom-kit"
 
@@ -220,6 +274,45 @@ def test_contribute_custom_commands(
         # Should complete successfully
         assert result.exit_code == 0
 
+    @patch("metaspec.cli.contribute.SpeckitValidator")
+    def test_contribute_check_only_passing(self, mock_validator_class: MagicMock) -> None:
+        """Test --check-only flag with passing validation."""
+        # Mock validation passing
+        mock_validator = MagicMock()
+        mock_validator.validate.return_value = create_passing_validation_result()
+        mock_validator_class.return_value = mock_validator
+
+        result = runner.invoke(app, ["contribute", "--check-only"])
+
+        # Should exit with 0 when validation passes
+        assert result.exit_code == 0
+        # Validation was called
+        assert mock_validator.validate.called
+        assert mock_validator.display_results.called
+
+    @patch("metaspec.cli.contribute.SpeckitValidator")
+    def test_contribute_check_only_failing(self, mock_validator_class: MagicMock) -> None:
+        """Test --check-only flag with failing validation."""
+        # Mock validation failing
+        failing_checks = [
+            ValidationCheck(
+                name="pyproject.toml",
+                passed=False,
+                message="pyproject.toml not found",
+                fix_suggestion="Create pyproject.toml",
+            ),
+        ]
+        mock_validator = MagicMock()
+        mock_validator.validate.return_value = ValidationResult(
+            checks=failing_checks, passed=False, warnings=["Missing files"]
+        )
+        mock_validator_class.return_value = mock_validator
+
+        result = runner.invoke(app, ["contribute", "--check-only"])
+
+        # Should exit with 1 when validation fails
+        assert result.exit_code == 1
+
     def test_contribute_non_interactive_fails(self) -> None:
         """Test that non-interactive mode shows error."""
         result = runner.invoke(