Merge pull request #11 from NK29/master

Revit 2022 migration-Deprecated API usage problem resolved

Author: Jeremy Tammik

Labs/1_Revit_API_Intro/SourceCS/3_ElementFiltering.cs

@@ -388,7 +388,7 @@ FilterStringRuleEvaluator evaluator
         = new FilterStringEquals();
 
       FilterRule rule = new FilterStringRule(
-        provider, evaluator, wallTypeName, true);
+        provider, evaluator, wallTypeName);
 
       ElementParameterFilter filter
         = new ElementParameterFilter(rule);

Labs/1_Revit_API_Intro/SourceCS/7_SharedParameter.cs

@@ -87,8 +87,9 @@ public Result Execute(
       bool visible = cat.AllowsBoundParameters;
 
       // Get or create the shared params definition
-      Definition fireRatingParamDef = GetOrCreateSharedParamsDefinition(
-        sharedParamsGroup, ParameterType.Number, kSharedParamsDefFireRating, visible);
+         ForgeTypeId forgeTypeId = new ForgeTypeId(SpecTypeId.Number.ToString());
+         Definition fireRatingParamDef = GetOrCreateSharedParamsDefinition(
+        sharedParamsGroup, forgeTypeId, kSharedParamsDefFireRating, visible);
       if (null == fireRatingParamDef)
       {
         message = "Error in creating shared parameter.";
@@ -195,15 +196,15 @@ public static DefinitionGroup GetOrCreateSharedParamsGroup(
 
     public static Definition GetOrCreateSharedParamsDefinition(
       DefinitionGroup defGroup,
-      ParameterType defType,
+      ForgeTypeId forgeTypeId,
       string defName,
       bool visible)
     {
       Definition definition = defGroup.Definitions.get_Item(defName);
       if (null == definition)
       {
         try
-        {
+        {          
           //definition = defGroup.Definitions.Create(defName, defType, visible);
 
           // 'Autodesk.Revit.DB.Definitions.Create(string, Autodesk.Revit.DB.ParameterType, bool)' is obsolete: 
@@ -214,7 +215,7 @@ public static Definition GetOrCreateSharedParamsDefinition(
 
           ExternalDefinitionCreationOptions opt
             = new ExternalDefinitionCreationOptions(
-              defName, defType);
+              defName, forgeTypeId);
           opt.Visible = true;
           definition = defGroup.Definitions.Create(opt);
         }
@@ -261,14 +262,14 @@ public Result Execute(
           return Result.Failed;
         }
         // visible param
-        Definition docParamDefVisible = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, ParameterType.Integer, kParamNameVisible, true);
+        Definition docParamDefVisible = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, new ForgeTypeId(SpecTypeId.Number.ToString()), kParamNameVisible, true);
         if (null == docParamDefVisible)
         {
           TaskDialog.Show("Per document parameter", "Error creating visible per-doc parameter.");
           return Result.Failed;
         }
         // invisible param
-        Definition docParamDefInvisible = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, ParameterType.Integer, kParamNameInvisible, false);
+        Definition docParamDefInvisible = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, new ForgeTypeId(SpecTypeId.Number.ToString()), kParamNameInvisible, false);
         if (null == docParamDefInvisible)
         {
           TaskDialog.Show("Per document parameter", "Error creating invisible per-doc parameter.");

Labs/1_Revit_API_Intro/SourceVB/3_ElementFiltering.vb

@@ -363,9 +363,9 @@ Public Class ElementFiltering
 
     Dim evaluator As FilterStringRuleEvaluator = New FilterStringEquals()
 
-    Dim rule As FilterRule = New FilterStringRule(provider, evaluator, wallTypeName, True)
+        Dim rule As FilterRule = New FilterStringRule(provider, evaluator, wallTypeName)
 
-    Dim filter As New ElementParameterFilter(rule)
+        Dim filter As New ElementParameterFilter(rule)
 
     Return New FilteredElementCollector(_doc).OfClass(GetType(WallType)).WherePasses(filter).FirstElement()
 

Labs/1_Revit_API_Intro/SourceVB/7_SharedParameter.vb

@@ -82,9 +82,10 @@ Class SharedParameter
     ' parameters can still be bound to these categories. 
     Dim visible As Boolean = cat.AllowsBoundParameters
 
-    ' Get or create the shared params definition
-    Dim fireRatingParamDef As Definition = GetOrCreateSharedParamsDefinition(sharedParamsGroup, ParameterType.Number, kSharedParamsDefFireRating, visible)
-    If fireRatingParamDef Is Nothing Then
+        ' Get or create the shared params definition
+        Dim forgeTypeId As ForgeTypeId = New ForgeTypeId(SpecTypeId.Number.ToString())
+        Dim fireRatingParamDef As Definition = GetOrCreateSharedParamsDefinition(sharedParamsGroup, forgeTypeId, kSharedParamsDefFireRating, visible)
+        If fireRatingParamDef Is Nothing Then
       message = "Error in creating shared parameter."
       Return Result.Failed
     End If
@@ -164,31 +165,30 @@ Class SharedParameter
     Return g
   End Function
 
-  Public Shared Function GetOrCreateSharedParamsDefinition(ByVal defGroup As DefinitionGroup, ByVal defType As ParameterType, ByVal defName As String, ByVal visible As Boolean) As Definition
-    Dim definition As Definition = defGroup.Definitions.Item(defName)
-    If definition Is Nothing Then
-      Try
-
-        ''Public Function Create(name As String, type As Autodesk.Revit.DB.ParameterType, visible As Boolean) 
-        ''As Autodesk.Revit.DB.Definition' is obsolete: 
-        'This method is deprecated in Revit 2015. 
-        'Use Create(Autodesk.Revit.DB.ExternalDefinitonCreationOptions) instead'
-
-        'definition = defGroup.Definitions.Create(defName, defType, visible)
-
-        ' updated for Revit 2015
-        Dim extDefCrOptions As ExternalDefinitionCreationOptions _
-          = New ExternalDefinitionCreationOptions(defName, defType)
-
-        extDefCrOptions.Visible = True
-        definition = defGroup.Definitions.Create(extDefCrOptions)
-
-      Catch generatedExceptionName As Exception
-        definition = Nothing
-      End Try
-    End If
-    Return definition
-  End Function
+    Public Shared Function GetOrCreateSharedParamsDefinition(ByVal defGroup As DefinitionGroup, ByVal forgetypeId As ForgeTypeId, ByVal defName As String, ByVal visible As Boolean) As Definition
+        Dim definition As Definition = defGroup.Definitions.Item(defName)
+        If definition Is Nothing Then
+            Try
+                ''Public Function Create(name As String, type As Autodesk.Revit.DB.ParameterType, visible As Boolean) 
+                ''As Autodesk.Revit.DB.Definition' is obsolete: 
+                'This method is deprecated in Revit 2015. 
+                'Use Create(Autodesk.Revit.DB.ExternalDefinitonCreationOptions) instead'
+
+                'definition = defGroup.Definitions.Create(defName, defType, visible)
+
+                ' updated for Revit 2015
+                Dim extDefCrOptions As ExternalDefinitionCreationOptions _
+                  = New ExternalDefinitionCreationOptions(defName, forgetypeId)
+
+                extDefCrOptions.Visible = True
+                definition = defGroup.Definitions.Create(extDefCrOptions)
+
+            Catch generatedExceptionName As Exception
+                definition = Nothing
+            End Try
+        End If
+        Return definition
+    End Function
 End Class
 
 <Transaction(TransactionMode.Manual)> _
@@ -219,15 +219,15 @@ Public Class PerDocParameter
         TaskDialog.Show("Per document parameter", "Error getting the shared params group.")
         Return Result.Failed
       End If
-      ' visible param
-      Dim docParamDefVisible As Definition = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, ParameterType.[Integer], kParamNameVisible, True)
-      If docParamDefVisible Is Nothing Then
+            ' visible param
+            Dim docParamDefVisible As Definition = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, New ForgeTypeId(SpecTypeId.Number.ToString()), kParamNameVisible, True)
+            If docParamDefVisible Is Nothing Then
         TaskDialog.Show("Per document parameter", "Error creating visible per-doc parameter.")
         Return Result.Failed
       End If
-      ' invisible param
-      Dim docParamDefInvisible As Definition = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, ParameterType.[Integer], kParamNameInvisible, False)
-      If docParamDefInvisible Is Nothing Then
+            ' invisible param
+            Dim docParamDefInvisible As Definition = SharedParameter.GetOrCreateSharedParamsDefinition(sharedParamsGroup, New ForgeTypeId(SpecTypeId.Number.ToString()), kParamNameInvisible, False)
+            If docParamDefInvisible Is Nothing Then
         TaskDialog.Show("Per document parameter", "Error creating invisible per-doc parameter.")
         Return Result.Failed
       End If