Merge pull request #8 from NK29/master

migration from Revit 2020 to Revit 2021

Author: Jeremy Tammik

Labs/1_Revit_API_Intro/DocsCS/Revit Intro Lab1 - Hello World.docx

@@ -9,7 +9,7 @@
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>IntroCs</RootNamespace>
-    <TargetFrameworkVersion>v4.7</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <FileUpgradeFlags>
     </FileUpgradeFlags>

Labs/1_Revit_API_Intro/DocsVB/Revit Intro Lab1 - Hello World.docx

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion( "2020.0.0.0" )]
-[assembly: AssemblyFileVersion( "2020.0.0.0" )]
+[assembly: AssemblyVersion( "2021.0.0.0" )]
+[assembly: AssemblyFileVersion( "2021.0.0.0" )]

Labs/1_Revit_API_Intro/SourceCS/IntroCs.csproj

@@ -10,7 +10,7 @@
     <RootNamespace>IntroVb</RootNamespace>
     <FileAlignment>512</FileAlignment>
     <MyType>Windows</MyType>
-    <TargetFrameworkVersion>v4.7</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
     <OptionExplicit>On</OptionExplicit>
     <OptionCompare>Binary</OptionCompare>
     <OptionStrict>Off</OptionStrict>

Labs/1_Revit_API_Intro/SourceCS/Properties/AssemblyInfo.cs

@@ -31,5 +31,5 @@ Imports System.Runtime.InteropServices
 ' by using the '*' as shown below:
 ' <Assembly: AssemblyVersion("1.0.*")> 
 
-<Assembly: AssemblyVersion("2020.0.0.0")>
-<Assembly: AssemblyFileVersion("2020.0.0.0")>
+<Assembly: AssemblyVersion("2021.0.0.0")>
+<Assembly: AssemblyFileVersion("2021.0.0.0")>

Labs/1_Revit_API_Intro/SourceVB/IntroVb.vbproj

@@ -184,33 +184,39 @@ public void PickMethod_PickObject()
     /// Note: when you run this code, you will see "Finish" and "Cancel" buttons in the dialog bar. 
     /// </summary>
     public void PickMethod_PickObjects()
-    {
-      IList<Reference> refs = _uiDoc.Selection.PickObjects(ObjectType.Element, "Select multiple elemens");
-
-      // Put it in a List form. 
-      IList<Element> elems = new List<Element>();
-      foreach (Reference r in refs)
       {
-        //elems.Add( r.Element ); // 2011 Warning: 'Autodesk.Revit.DB.Reference.Element' is obsolete: 
-        // 'Property will be removed. Use Document.GetElement(Reference) instead'
-        elems.Add(_uiDoc.Document.GetElement(r)); // 2012
+            IList<Reference> refs = _uiDoc.Selection.PickObjects(ObjectType.Element, "Select multiple elemens");
+
+            // Put it in a List form. 
+            IList<ElementId> elems = new List<ElementId>();
+            foreach (Reference r in refs)
+            {
+                //elems.Add( r.Element ); // 2011 Warning: 'Autodesk.Revit.DB.Reference.Element' is obsolete: 
+                // 'Property will be removed. Use Document.GetElement(Reference) instead'
+                elems.Add(r.ElementId); // 2012
+            }
+
+            ShowElementList(elems, "Pick Objects: ");
       }
 
-      ShowElementList(elems, "Pick Objects: ");
-    }
 
     /// <summary>
     /// Minimum PickElementByRectangle 
     /// </summary>
     public void PickMethod_PickElementByRectangle()
-    {
-      // Note: PickElementByRectangle returns the list of element. not reference. 
-      IList<Element> elems = _uiDoc.Selection.PickElementsByRectangle("Select by rectangle");
-
-      // Show it. 
+      {
+            // Note: PickElementByRectangle returns the list of element. not reference. 
+            IList<Element> elems = _uiDoc.Selection.PickElementsByRectangle("Select by rectangle");
+            IList<ElementId> eids = new List<ElementId>();
+            foreach(Element e in elems)
+            {
+                eids.Add(e.Id);
+            }
+            // Show it. 
+
+            ShowElementList(eids, "Pick By Rectangle: ");
+      }
 
-      ShowElementList(elems, "Pick By Rectangle: ");
-    }
 
     /// <summary>
     /// Minimum PickPoint 
@@ -268,7 +274,7 @@ public void PickEdge()
       Reference r = _uiDoc.Selection.PickObject(ObjectType.Edge, "Select an edge");
       Element e = _uiDoc.Document.GetElement(r);
       //Edge oEdge = r.GeometryObject as Edge; // 2011
-      Face oEdge = e.GetGeometryObjectFromReference(r) as Face; // 2012
+      Edge oEdge = e.GetGeometryObjectFromReference(r) as Edge; // 2012
 
       // Show it. 
       string msg = "";
@@ -558,11 +564,11 @@ public Result Execute(
       _uiDoc = _uiApp.ActiveUIDocument;
       _doc = _uiDoc.Document;
 
-      using (Transaction transaction = new Transaction(_doc))
+    //  using (Transaction transaction = new Transaction(_doc))
       {
-        transaction.Start("Create House");
+     //   transaction.Start("Create House");
         CreateHouseInteractive(_uiDoc);
-        transaction.Commit();
+     //   transaction.Commit();
       }
 
       return Result.Succeeded;

Labs/1_Revit_API_Intro/SourceVB/My Project/AssemblyInfo.vb

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion( "2020.0.0.0" )]
-[assembly: AssemblyFileVersion( "2020.0.0.0" )]
+[assembly: AssemblyVersion( "2021.0.0.0" )]
+[assembly: AssemblyFileVersion( "2021.0.0.0" )]