Skip to content

Commit 0489026

Browse files
committed
fix(configure) : updated files to remove secrets , fix check passing
1 parent 55dc94c commit 0489026

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

docs/keycloak-sso-integration.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Because Keycloak is the strict source of truth, any roles assigned manually with
5656

5757
**To grant a user access to Grafana:**
5858
1. A System Administrator must log into the Keycloak Admin Console.
59-
2. Navigate to the target Realm (e.g., `argocd`).
59+
2. Navigate to the target Realm (e.g., `<realm>`).
6060
3. Create the user or locate an existing user.
6161
4. Navigate to the user's **Groups** tab.
6262
5. Join the user to either `grafana-admins`, `grafana-editors`, or `grafana-viewers`.
@@ -66,8 +66,8 @@ Upon their next login, Grafana will automatically sync the user and grant them t
6666
## 5. Required CI/CD Secrets
6767
For this configuration to deploy successfully via GitHub Actions, the following secrets must be present in the repository:
6868

69-
1. `KEYCLOAK_URL` (e.g., `https://accounts.ssegning.com`)
70-
2. `KEYCLOAK_REALM` (e.g., `argocd`)
69+
1. `KEYCLOAK_URL` (e.g., `https://<keycloak-domain>/<realm>.com`)
70+
2. `KEYCLOAK_REALM` (e.g., `<realm>`)
7171
3. `KEYCLOAK_ADMIN_USER`
7272
4. `KEYCLOAK_ADMIN_PASSWORD`
7373
5. `GRAFANA_KEYCLOAK_USER` (The dedicated Grafana admin username)

lgtm-stack/terraform/keycloak.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Keycloak Terraform Configuration — Grafana SSO
33
# ============================================================
44
# This file automates the full Keycloak-side setup inside the
5-
# existing "argocd" realm on accounts.ssegning.com (shared with ArgoCD).
5+
# existing realm on <keycloak-domain> (shared with Auth/SSO).
66
#
77
# What it creates:
88
# 1. OpenID Connect client: grafana-oauth

lgtm-stack/terraform/main.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ provider "keycloak" {
7373
client_id = "admin-cli"
7474
username = var.keycloak_admin_user
7575
password = var.keycloak_admin_password
76-
url = var.keycloak_url # https://accounts.ssegning.com
76+
url = var.keycloak_url # https://<keycloak-domain>
7777
realm = var.keycloak_realm
7878

7979
# base_path is NOT set — correct for Keycloak 17+ (Quarkus distribution)
@@ -348,11 +348,11 @@ resource "helm_release" "grafana" {
348348
ingress_class_name = var.ingress_class_name
349349
cert_issuer_name = var.cert_issuer_name
350350
# Keycloak OAuth2 — URL and realm for grafana.ini endpoint construction
351-
keycloak_url = var.keycloak_url
352-
keycloak_realm = var.keycloak_realm
351+
keycloak_url = var.keycloak_url
352+
keycloak_realm = var.keycloak_realm
353353
# Client secret is read directly from the Keycloak Terraform resource
354354
# (no manual copy-paste or separate secret management needed)
355-
keycloak_client_secret = keycloak_openid_client.grafana.client_secret
355+
keycloak_client_secret = keycloak_openid_client.grafana.client_secret
356356
})
357357
]
358358

lgtm-stack/terraform/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,12 +230,12 @@ variable "force_destroy" {
230230
# No defaults are set here to enforce that secrets are always explicitly provided.
231231

232232
variable "keycloak_url" {
233-
description = "Base URL of the Keycloak server, no trailing slash, no /auth suffix (KC 17+ Quarkus). e.g. https://accounts.ssegning.com"
233+
description = "Base URL of the Keycloak server, no trailing slash, no /auth suffix (KC 17+ Quarkus). e.g. https://<keycloak-domain>"
234234
type = string
235235
}
236236

237237
variable "keycloak_realm" {
238-
description = "Keycloak realm where the Grafana OIDC client and roles will be created. Must already exist. e.g. argocd"
238+
description = "Keycloak realm where the Grafana OIDC client and roles will be created. Must already exist. e.g. <realm>"
239239
type = string
240240
}
241241

0 commit comments

Comments
 (0)