Skip to content

Commit d14c358

Browse files
committed
Remove emojis from CD pipeline and ArgoCD docs
1 parent 8e60359 commit d14c358

File tree

3 files changed

+36
-36
lines changed

3 files changed

+36
-36
lines changed

.github/workflows/cd-app-pipeline.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "🚀 Build & Deploy (GitOps)"
1+
name: "Build & Deploy (GitOps)"
22

33
on:
44
# This is a TEMPLATE — copy it into your own app repo and set your trigger.
@@ -8,7 +8,7 @@ on:
88
# workflow_dispatch: # Manual trigger from the GitHub Actions UI
99
workflow_dispatch:
1010

11-
# ── ✏️ CONFIGURE THESE ──────────────────────────────────────────────────────
11+
# ── CONFIGURE THESE ─────────────────────────────────────────────────────────
1212
env:
1313
# 1. Container registry (ghcr.io = GitHub, docker.io = Docker Hub)
1414
REGISTRY: ghcr.io
@@ -30,17 +30,17 @@ jobs:
3030
packages: write # Push image to GHCR
3131

3232
steps:
33-
- name: "📥 Checkout app code"
33+
- name: "Checkout app code"
3434
uses: actions/checkout@v4
3535

36-
- name: "🔑 Log in to registry"
36+
- name: "Log in to registry"
3737
uses: docker/login-action@v3
3838
with:
3939
registry: ${{ env.REGISTRY }}
4040
username: ${{ github.actor }}
4141
password: ${{ secrets.GITHUB_TOKEN }} # Automatically provided by GitHub — no setup needed
4242

43-
- name: "🏷️ Generate image tags"
43+
- name: "Generate image tags"
4444
id: meta
4545
uses: docker/metadata-action@v5
4646
with:
@@ -49,10 +49,10 @@ jobs:
4949
type=sha,prefix=sha-,format=short # e.g. sha-a1b2c3d
5050
type=raw,value=latest,enable=${{ github.ref == 'refs/heads/main' }}
5151
52-
- name: "⚙️ Set up Docker Buildx"
52+
- name: "Set up Docker Buildx"
5353
uses: docker/setup-buildx-action@v3
5454

55-
- name: "🐳 Build & push image"
55+
- name: "Build & push image"
5656
id: push
5757
uses: docker/build-push-action@v5
5858
with:
@@ -70,29 +70,29 @@ jobs:
7070
steps:
7171
# Checkout the GITOPS repo (not this one)
7272
# Requires secret: GITOPS_REPO_PAT
73-
- name: "📥 Checkout GitOps repo"
73+
- name: "Checkout GitOps repo"
7474
uses: actions/checkout@v4
7575
with:
7676
repository: ${{ env.GITOPS_REPO }}
7777
token: ${{ secrets.GITOPS_REPO_PAT }}
7878
path: gitops-repo
7979

80-
- name: "✍️ Update image tag in deployment.yaml"
80+
- name: "Update image tag in deployment.yaml"
8181
run: |
8282
# Build the new image reference (lowercase, with SHA tag)
8383
NEW_IMAGE="${{ env.REGISTRY }}/${{ github.repository_owner }}/$(basename ${{ github.repository }}):sha-$(echo ${{ github.sha }} | cut -c1-7)"
8484
NEW_IMAGE=$(echo $NEW_IMAGE | tr '[:upper:]' '[:lower:]')
8585
86-
echo "🏷️ New image: $NEW_IMAGE"
86+
echo "New image: $NEW_IMAGE"
8787
8888
# Replace the "image:" line in the manifest
8989
sed -i "s|image: .*|image: $NEW_IMAGE|g" gitops-repo/deployment.yaml
9090
91-
- name: "📤 Commit & push to GitOps repo"
91+
- name: "Commit & push to GitOps repo"
9292
run: |
9393
cd gitops-repo
9494
git config user.name "github-actions[bot]"
9595
git config user.email "github-actions[bot]@users.noreply.github.com"
9696
git add deployment.yaml
97-
git commit -m "🚀 deploy: update image → sha-${{ github.sha }}" || echo "Nothing to commit"
97+
git commit -m "deploy: update image → sha-${{ github.sha }}" || echo "Nothing to commit"
9898
git push

docs/argocd-agent-github-actions.md

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ Two workflows automate the deployment:
1818

1919
Before running workflows, ensure:
2020

21-
- [ ] Netbird account created
22-
- [ ] Spoke clusters installed Netbird and registered (persistent peers)
23-
- [ ] GitHub runners setup key created (ephemeral)
24-
- [ ] ACLs configured (`github-runners``spoke-clusters`, TCP port 6443)
25-
- [ ] GKE cluster exists for hub deployment
26-
- [ ] All GitHub Secrets configured (see [Netbird Setup Guide](netbird-setup-guide.md#6-github-secrets-configuration))
21+
- [ ] Netbird account created
22+
- [ ] Spoke clusters installed Netbird and registered (persistent peers)
23+
- [ ] GitHub runners setup key created (ephemeral)
24+
- [ ] ACLs configured (`github-runners``spoke-clusters`, TCP port 6443)
25+
- [ ] GKE cluster exists for hub deployment
26+
- [ ] All GitHub Secrets configured (see [Netbird Setup Guide](netbird-setup-guide.md#6-github-secrets-configuration))
2727

2828
---
2929

@@ -79,7 +79,7 @@ After successful deployment:
7979

8080
**Example output**:
8181
```
82-
📊 Deployment Summary:
82+
Deployment Summary:
8383
{
8484
"argocd_url": "https://argocd.example.com",
8585
"principal_address": "34.123.45.67",
@@ -99,7 +99,7 @@ After successful deployment, you can verify the deployment details in the workfl
9999

100100
**Example output**:
101101
```
102-
📊 Deployment Summary:
102+
Deployment Summary:
103103
{
104104
"argocd_url": "https://argocd.example.com",
105105
"principal_address": "34.123.45.67",
@@ -155,16 +155,16 @@ Check the **"Verify ArgoCD Spoke deployment"** step output:
155155
Verifying spoke-2...
156156
═══════════════════════════════════════════════════════════
157157
1. Checking namespace...
158-
Namespace exists
158+
Namespace exists
159159
2. Checking ArgoCD pods...
160-
All pods ready
160+
All pods ready
161161
3. Checking agent connection...
162-
Agent connected to principal
162+
Agent connected to principal
163163
4. Checking certificates...
164-
Client certificate exists
165-
CA certificate exists
164+
Client certificate exists
165+
CA certificate exists
166166
167-
All spoke clusters deployed and connected successfully!
167+
All spoke clusters deployed and connected successfully!
168168
```
169169

170170
---
@@ -195,10 +195,10 @@ Use `adopt_existing_resources=true` when:
195195
════════════════════════════════════════════════════════════════
196196
Checking for existing ArgoCD resources to import...
197197
════════════════════════════════════════════════════════════════
198-
Found existing argocd namespace
198+
Found existing argocd namespace
199199
Importing into Terraform state...
200200
Successfully imported kubernetes_namespace.hub_argocd
201-
Found existing ArgoCD Helm release
201+
Found existing ArgoCD Helm release
202202
════════════════════════════════════════════════════════════════
203203
Import check complete! Proceeding with Terraform operations...
204204
════════════════════════════════════════════════════════════════
@@ -487,10 +487,10 @@ kubectl get pods -n guestbook-helm --context spoke-2
487487
**Q: How do I verify spoke clusters are successfully connected?**
488488

489489
**A:** Check the workflow logs for the "Verify ArgoCD Spoke deployment" step. Look for all green checkmarks:
490-
- Namespace exists
491-
- All pods ready
492-
- Agent connected to principal
493-
- Client certificate exists
490+
- Namespace exists
491+
- All pods ready
492+
- Agent connected to principal
493+
- Client certificate exists
494494

495495
Or verify manually: `kubectl --context=spoke-2 logs -n argocd -l app.kubernetes.io/name=argocd-agent --tail=20 | grep "connected"`
496496

docs/netbird-setup-guide.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -492,10 +492,10 @@ sudo netstat -tlnp | grep 6443
492492

493493
Once Netbird setup is complete:
494494

495-
1. Spoke clusters registered in Netbird
496-
2. Setup keys created and stored in GitHub Secrets
497-
3. ACLs configured
498-
4. Spoke Netbird IPs and credentials stored in GitHub Secrets
495+
1. Spoke clusters registered in Netbird
496+
2. Setup keys created and stored in GitHub Secrets
497+
3. ACLs configured
498+
4. Spoke Netbird IPs and credentials stored in GitHub Secrets
499499

500500
**You're ready to run the GitHub Actions workflows!**
501501

0 commit comments

Comments
 (0)